-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security best practices - 10 points to consider - #5782 #7113
Security best practices - 10 points to consider - #5782 #7113
Conversation
@hdhalter can I bring your attention to the first draft of the security best practices document please. @AntonEliatra is adding more information tomorrow and many of the topics will be expanded on. Please add the security tag to this ticket too so it shows up on the list of PRs, thanks a million. |
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
c1363db
to
d831f8a
Compare
Signed-off-by: AntonEliatra <[email protected]>
…ra/opensearch-documentation-website-forl into best-practice3
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@hdhalter cc @scrawfor99 Ready for review. Thanks a million. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leanneeliatra @Naarcha-AWS Please see my comments and changes and tag me for approval when complete. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@natebower thats been updated now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Naarcha-AWS @AntonEliatra @leanneeliatra Some outstanding comments. Thanks!
### Replace all demo certificates with your own PKI | ||
The certificates generated when initializing an OpenSearch cluster with `install_demo_configuration.sh` are not suitable for production. These should be replaced with your own certificates. | ||
|
||
You can generate custom certificates in a few different ways. One approach is to use OpenSSL, described in detail at [Generating self-signed certificates]({{site.url}}{{site.baseurl}}/security/configuration/generate-certificates/). Alternatively, there are online tools available that can simplify the certificate creation process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that @Naarcha-AWS and I's comments here have been addressed.
|
||
## 10. Stay informed and apply updates | ||
|
||
Regularly monitor OpenSearch Project security advisories and updates to stay informed about potential vulnerabilities or bugs. Promptly apply updates to the Security plugin and its dependencies to maintain a secure environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like my comment re: a link has not been addressed.
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @leanneeliatra @AntonEliatra @Naarcha-AWS! LGTM once the remaining comment is resolved.
Hi @natebower thanks a million. |
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Naarcha-AWS LGTM with the noted changes. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
* adding top ten security best practices Signed-off-by: [email protected] <[email protected]> * changing nav order Signed-off-by: [email protected] <[email protected]> * adding to best practices Signed-off-by: AntonEliatra <[email protected]> * adding to best practices Signed-off-by: AntonEliatra <[email protected]> * adding to best practices Signed-off-by: AntonEliatra <[email protected]> * adding bonus tip Signed-off-by: [email protected] <[email protected]> * updates to best practices Signed-off-by: [email protected] <[email protected]> * integrating Darshits suggestions for improvement and reviewdog fixes Signed-off-by: [email protected] <[email protected]> * review suggestions to grammer Signed-off-by: [email protected] <[email protected]> * review suggestions to grammer Signed-off-by: [email protected] <[email protected]> * review suggestions to grammer Signed-off-by: [email protected] <[email protected]> * review suggestions to grammer Signed-off-by: [email protected] <[email protected]> * review suggestions to grammer Signed-off-by: [email protected] <[email protected]> * reviewdog update Signed-off-by: [email protected] <[email protected]> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * reviewdog updates Signed-off-by: [email protected] <[email protected]> * Update _security/configuration/best-practices.md Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Update best-practices.md Signed-off-by: AntonEliatra <[email protected]> * Update best-practices.md Signed-off-by: AntonEliatra <[email protected]> * Add editorial comment Signed-off-by: Naarcha-AWS <[email protected]> * Update best-practices.md Signed-off-by: AntonEliatra <[email protected]> * Update _security/configuration/best-practices.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Update best-practices.md Signed-off-by: AntonEliatra <[email protected]> * Update best-practices.md Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: [email protected] <[email protected]> Signed-off-by: AntonEliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: AntonEliatra <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 8e049cd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…5782 (opensearch-project#7113) * adding top ten security best practices Signed-off-by: [email protected] <[email protected]> * changing nav order Signed-off-by: [email protected] <[email protected]> * adding to best practices Signed-off-by: AntonEliatra <[email protected]> * adding to best practices Signed-off-by: AntonEliatra <[email protected]> * adding to best practices Signed-off-by: AntonEliatra <[email protected]> * adding bonus tip Signed-off-by: [email protected] <[email protected]> * updates to best practices Signed-off-by: [email protected] <[email protected]> * integrating Darshits suggestions for improvement and reviewdog fixes Signed-off-by: [email protected] <[email protected]> * review suggestions to grammer Signed-off-by: [email protected] <[email protected]> * review suggestions to grammer Signed-off-by: [email protected] <[email protected]> * review suggestions to grammer Signed-off-by: [email protected] <[email protected]> * review suggestions to grammer Signed-off-by: [email protected] <[email protected]> * review suggestions to grammer Signed-off-by: [email protected] <[email protected]> * reviewdog update Signed-off-by: [email protected] <[email protected]> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * reviewdog updates Signed-off-by: [email protected] <[email protected]> * Update _security/configuration/best-practices.md Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Update best-practices.md Signed-off-by: AntonEliatra <[email protected]> * Update best-practices.md Signed-off-by: AntonEliatra <[email protected]> * Add editorial comment Signed-off-by: Naarcha-AWS <[email protected]> * Update best-practices.md Signed-off-by: AntonEliatra <[email protected]> * Update _security/configuration/best-practices.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Update best-practices.md Signed-off-by: AntonEliatra <[email protected]> * Update best-practices.md Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: [email protected] <[email protected]> Signed-off-by: AntonEliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: AntonEliatra <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Description
We are adding a new page in the documentation, outlining the best practices/considerations for security in OpenSearch.
Covering the ten points below:
Issues Resolved
Closes #5782
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.