Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security best practices - 10 points to consider - #5782 #7113

Merged

Conversation

leanneeliatra
Copy link
Contributor

@leanneeliatra leanneeliatra commented May 8, 2024

Description

We are adding a new page in the documentation, outlining the best practices/considerations for security in OpenSearch.
Covering the ten points below:

  1. Use your own PKI (public key infrastructure) to setup SSL/TLS for OpenSearch
  2. Prefer client certificate authentication for API authentication
  3. Prefer SSO using SAML or OpenID for Dashboards authentication
  4. Limit the number of roles assigned to a user
  5. Verify DLS, FLS and field masking
  6. Strip audit logging configuration to essentials only
  7. Explore disabling private tenant
  8. Manage the configuration via securityadmin.sh
  9. Replace all default passwords
  10. Stay informed and apply updates

Issues Resolved

Closes #5782

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@leanneeliatra leanneeliatra changed the title Security best practices 5782 [DRAFT] Security best practices 5782 May 8, 2024
@leanneeliatra
Copy link
Contributor Author

@hdhalter can I bring your attention to the first draft of the security best practices document please. @AntonEliatra is adding more information tomorrow and many of the topics will be expanded on.

Please add the security tag to this ticket too so it shows up on the list of PRs, thanks a million.

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. security backport 2.13 PR: Backport label for 2.13 labels May 8, 2024
@leanneeliatra leanneeliatra changed the title [DRAFT] Security best practices 5782 Security best practices - 10 points to consider - #5782 May 14, 2024
@leanneeliatra
Copy link
Contributor Author

@hdhalter cc @scrawfor99 Ready for review. Thanks a million.

@hdhalter hdhalter added 3 - Tech review PR: Tech review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels May 14, 2024
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels May 21, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leanneeliatra @Naarcha-AWS Please see my comments and changes and tag me for approval when complete. Thanks!

_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
leanneeliatra and others added 2 commits May 22, 2024 13:26
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
Copy link
Contributor

@natebower thats been updated now

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS @AntonEliatra @leanneeliatra Some outstanding comments. Thanks!

### Replace all demo certificates with your own PKI
The certificates generated when initializing an OpenSearch cluster with `install_demo_configuration.sh` are not suitable for production. These should be replaced with your own certificates.

You can generate custom certificates in a few different ways. One approach is to use OpenSSL, described in detail at [Generating self-signed certificates]({{site.url}}{{site.baseurl}}/security/configuration/generate-certificates/). Alternatively, there are online tools available that can simplify the certificate creation process.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that @Naarcha-AWS and I's comments here have been addressed.

_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved

## 10. Stay informed and apply updates

Regularly monitor OpenSearch Project security advisories and updates to stay informed about potential vulnerabilities or bugs. Promptly apply updates to the Security plugin and its dependencies to maintain a secure environment.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like my comment re: a link has not been addressed.

AntonEliatra and others added 3 commits May 22, 2024 16:45
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
AntonEliatra and others added 2 commits May 24, 2024 08:21
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leanneeliatra @AntonEliatra @Naarcha-AWS! LGTM once the remaining comment is resolved.

_security/configuration/best-practices.md Outdated Show resolved Hide resolved
@leanneeliatra
Copy link
Contributor Author

leanneeliatra commented May 28, 2024

@leanneeliatra @Naarcha-AWS Please see my comments and changes and tag me for approval when complete. Thanks!

Hi @natebower thanks a million.
Your changes are all integrated now and ready for review.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS LGTM with the noted changes. Thanks!

_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
_security/configuration/best-practices.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS merged commit 8e049cd into opensearch-project:main May 30, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 30, 2024
* adding top ten security best practices

Signed-off-by: [email protected] <[email protected]>

* changing nav order

Signed-off-by: [email protected] <[email protected]>

* adding to best practices

Signed-off-by: AntonEliatra <[email protected]>

* adding to best practices

Signed-off-by: AntonEliatra <[email protected]>

* adding to best practices

Signed-off-by: AntonEliatra <[email protected]>

* adding bonus tip

Signed-off-by: [email protected] <[email protected]>

* updates to best practices

Signed-off-by: [email protected] <[email protected]>

* integrating Darshits suggestions for improvement and reviewdog fixes

Signed-off-by: [email protected] <[email protected]>

* review suggestions to grammer

Signed-off-by: [email protected] <[email protected]>

* review suggestions to grammer

Signed-off-by: [email protected] <[email protected]>

* review suggestions to grammer

Signed-off-by: [email protected] <[email protected]>

* review suggestions to grammer

Signed-off-by: [email protected] <[email protected]>

* review suggestions to grammer

Signed-off-by: [email protected] <[email protected]>

* reviewdog update

Signed-off-by: [email protected] <[email protected]>

* Apply suggestions from code review

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* reviewdog updates

Signed-off-by: [email protected] <[email protected]>

* Update _security/configuration/best-practices.md

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update best-practices.md

Signed-off-by: AntonEliatra <[email protected]>

* Update best-practices.md

Signed-off-by: AntonEliatra <[email protected]>

* Add editorial comment

Signed-off-by: Naarcha-AWS <[email protected]>

* Update best-practices.md

Signed-off-by: AntonEliatra <[email protected]>

* Update _security/configuration/best-practices.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Update best-practices.md

Signed-off-by: AntonEliatra <[email protected]>

* Update best-practices.md

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: AntonEliatra <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 8e049cd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
epugh pushed a commit to o19s/documentation-website that referenced this pull request May 30, 2024
…5782 (opensearch-project#7113)

* adding top ten security best practices

Signed-off-by: [email protected] <[email protected]>

* changing nav order

Signed-off-by: [email protected] <[email protected]>

* adding to best practices

Signed-off-by: AntonEliatra <[email protected]>

* adding to best practices

Signed-off-by: AntonEliatra <[email protected]>

* adding to best practices

Signed-off-by: AntonEliatra <[email protected]>

* adding bonus tip

Signed-off-by: [email protected] <[email protected]>

* updates to best practices

Signed-off-by: [email protected] <[email protected]>

* integrating Darshits suggestions for improvement and reviewdog fixes

Signed-off-by: [email protected] <[email protected]>

* review suggestions to grammer

Signed-off-by: [email protected] <[email protected]>

* review suggestions to grammer

Signed-off-by: [email protected] <[email protected]>

* review suggestions to grammer

Signed-off-by: [email protected] <[email protected]>

* review suggestions to grammer

Signed-off-by: [email protected] <[email protected]>

* review suggestions to grammer

Signed-off-by: [email protected] <[email protected]>

* reviewdog update

Signed-off-by: [email protected] <[email protected]>

* Apply suggestions from code review

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* reviewdog updates

Signed-off-by: [email protected] <[email protected]>

* Update _security/configuration/best-practices.md

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update best-practices.md

Signed-off-by: AntonEliatra <[email protected]>

* Update best-practices.md

Signed-off-by: AntonEliatra <[email protected]>

* Add editorial comment

Signed-off-by: Naarcha-AWS <[email protected]>

* Update best-practices.md

Signed-off-by: AntonEliatra <[email protected]>

* Update _security/configuration/best-practices.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Update best-practices.md

Signed-off-by: AntonEliatra <[email protected]>

* Update best-practices.md

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: AntonEliatra <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 5 - Editorial review PR: Editorial review in progress labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete backport 2.14 PR: Backport label for 2.14 security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add a new section in documentation for security best practices and recommendations.
7 participants