Replace sample.pem and test-kirk.jks to match other plugins #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt,
jowg-amazon,
r1walz and
vikasvb90
as code owners
vikasvb90
approved these changes
Mar 29, 2024
Hailong-am
approved these changes
Mar 29, 2024
|
Let's wait for security test CI finished |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
============================================
- Coverage 75.37% 75.32% -0.05%
+ Complexity 2814 2809 -5
============================================
Files 367 367
Lines 17038 17038
Branches 2370 2370
============================================
- Hits 12842 12834 -8
- Misses 2894 2902 +8
Partials 1302 1302 ☔ View full report in Codecov by Sentry. |
DarshitChanpura
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Thanks @cwperks !! You beat me to it. This should solve CI issues.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit e5a13ff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit e5a13ff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90
pushed a commit
that referenced
this pull request
Mar 29, 2024
…1149) (cherry picked from commit e5a13ff) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90
pushed a commit
that referenced
this pull request
Mar 29, 2024
…1148) (cherry picked from commit e5a13ff) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
sample.pemandtest-kirk.jksto match the reporting plugin and anomaly-detection pluginThis resolves integ test failures running with security.
When backporting to 2.x/2.13 there are more instances of
internal_elasticsearchthat should be replaced withinternal_opensearchinbuild.gradle.CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.