Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore assemble behavior by removing unittests for Windows during Jenkins build #601

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Oct 28, 2022

Signed-off-by: Peter Zhu [email protected]

Description

Restore assemble behavior by removing unittests for Windows during Jenkins build.
Initially we are running gradle assemble which does not run integTest or unittest during compiling.

Now due to integrate with multiple tasks such as windowsscript as well as running cmake through gradle, we have to switch to gradle build which cause the entire build to take around 1 hour plus to complete, compares to the original compile time 30min-40min.

By removing unittest during compilation this restored the original behavior of KNN build on Jenkins, while allowing gradle to take over the trigger of cmake/make.

Thanks.

Issues Resolved

opensearch-project/opensearch-build#2306

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added release v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 28, 2022
@peterzhuamazon peterzhuamazon self-assigned this Oct 28, 2022
@peterzhuamazon peterzhuamazon requested a review from a team October 28, 2022 06:40
@peterzhuamazon peterzhuamazon changed the title Restore assemble behavior by removing unittests Restore assemble behavior by removing unittests for Windows during Jenkins build Oct 28, 2022
@peterzhuamazon
Copy link
Member Author

Seems like removing the test somehow stopped the lib building.
Closing this.

@peterzhuamazon peterzhuamazon deleted the knn-2.4.0-build-1 branch October 28, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant