Add gcc version verification before building k-NN #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
navneet1v
reviewed
Jul 13, 2023
navneet1v
approved these changes
Jul 13, 2023
jmazanec15
approved these changes
Jul 13, 2023
peterzhuamazon
merged commit fe25c6d
into
opensearch-project:main
23 of 61 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit fe25c6d)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit fe25c6d)
navneet1v
pushed a commit
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit fe25c6d) Co-authored-by: Peter Zhu <[email protected]>
navneet1v
pushed a commit
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit fe25c6d) Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon
added
the
Enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add gcc version verification before building k-NN
Issues Resolved
#975
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.