Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NeuralQueryEnricher does not work with nested queries #2599

Closed
IanMenendez opened this issue Jun 29, 2024 · 2 comments
Closed

[BUG] NeuralQueryEnricher does not work with nested queries #2599

IanMenendez opened this issue Jun 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@IanMenendez
Copy link

NeuralQueryEnricher search processor is not working with NestedQueries
Other people are having the same issue: opensearch-project/OpenSearch#13961

how to reproduce:

PUT /_search/pipeline/test_pipeline 
{
  "request_processors": [
    {
      "neural_query_enricher" : {
        "default_model_id": "u5j0qYoBMtvQlfhaxOsa",
        "neural_field_default_id": {
           "embedding_field.knn": "uZj0qYoBMtvQlfhaYeud"
        }
      }
    }
  ]
}

GET testindex/_search?search_pipeline=test_pipeline
{
  "query": {
    "nested": {
      "score_mode": "max",
      "path": "passage_chunk_embedding",
      "query": {
        "neural": {
          "embedding_field.knn": {
            "query_text": "document"
          }
        }
      }
    }
  }
}

This should work but instead throws:

{
  "error": {
    "root_cause": [
      {
        "type": "null_pointer_exception",
        "reason": "modelId is marked non-null but is null"
      }
    ],
    "type": "null_pointer_exception",
    "reason": "modelId is marked non-null but is null"
  },
  "status": 500
}
@IanMenendez IanMenendez added bug Something isn't working untriaged labels Jun 29, 2024
@IanMenendez IanMenendez changed the title [BUG] [BUG] NeuralSearchEnricher does not work with nested queries Jun 29, 2024
@IanMenendez IanMenendez changed the title [BUG] NeuralSearchEnricher does not work with nested queries [BUG] NeuralQueryEnricher does not work with nested queries Jun 29, 2024
@mingshl
Copy link
Collaborator

mingshl commented Jul 2, 2024

this issue should go to neural search repo. neural_query_enricher processor is in neural search repo.

@IanMenendez
Copy link
Author

opened new issue in neural search repo as I was unable to transfer it. opensearch-project/neural-search#813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants