[Feature] Add NestedField Visit Method #13961
Closed
+24
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i use neural query in OpenSearch with nested field https://opensearch.org/docs/latest/search-plugins/semantic-search/#setting-a-default-model-on-an-index-or-field, but it can not calling model in search pipeline with
neural_query_enricher
processor like the doc shows.i think it is because NestedQueryBuilder do not support visit method like
boolean query
OpenSearch/server/src/main/java/org/opensearch/index/query/BoolQueryBuilder.java
Lines 432 to 439 in 581fcd2
it can not visit from processRequest like the following code do:
https://github.com/opensearch-project/neural-search/blob/2b21110be2d343e83f539e75104a8928522bf720/src/main/java/org/opensearch/neuralsearch/processor/NeuralQueryEnricherProcessor.java#L68-L75
BTW in #13837 i see it fixed many scenarios queries, but we still need
NestedQueryBuilder
to visit query builder.so this pr i added a visit method.