Backport/backport 208 to 2.x #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zan Niu <[email protected]>
Signed-off-by: Zan Niu <[email protected]>
…rch-project#208) * Fix update document with knnn_vector size not matching issue Signed-off-by: zane-neo <[email protected]> * Add apache common lang3 back to fix PR gradle build failure Signed-off-by: zane-neo <[email protected]> * Fix PR check failure Signed-off-by: zane-neo <[email protected]> * Fix PR check failure Signed-off-by: zane-neo <[email protected]> * Fix PR check jar hell failure Signed-off-by: zane-neo <[email protected]> * Add apache common lang back to fix the PR check Signed-off-by: zane-neo <[email protected]> * Fix register model group failure in IT Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> * Rename the method appendVectorFieldsToDocument to setVectorFieldsToDocument Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> (cherry picked from commit 9599371)
zane-neo
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
wujunshen,
ylwu-amzn and
jngz-es
as code owners
Signed-off-by: zane-neo <[email protected]>
navneet1v
reviewed
Jul 11, 2023
| @@ -36,6 +36,8 @@ public class MLCommonsClientAccessor { | |||
| private static final List<String> TARGET_RESPONSE_FILTERS = List.of("sentence_embedding"); | |||
| private final MachineLearningNodeClient mlClient; | |||
|
|
|||
| private static final int MAX_RETRY = 3; | |||
There was a problem hiding this comment.
Not sure, I followed the guidance of backport on github, this could be missing removal in previous backport PRs. I've removed this.
Signed-off-by: zane-neo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #210 +/- ##
=========================================
Coverage 89.55% 89.55%
Complexity 103 103
=========================================
Files 7 7
Lines 316 316
Branches 52 52
=========================================
Hits 283 283
Misses 16 16
Partials 17 17
|
martin-gaievski
approved these changes
Jul 11, 2023
|
@zane-neo we should close this PR. The backport has already happened for 2.x branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed the issue when updating a document with knn_vector field, the update fails because the vector dimension is not matching the required dimension. This PR is a backport PR of: #208
Issues Resolved
#207
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.