Consumed latest changes from core, use QueryPhaseSearcherWrapper as parent class for Hybrid QPS

[martin-gaievski]

Description

Need to use QueryPhaseSearcherWrapper as this is core new public implementation of the QueryPhaseSearcher. This will be released in core 2.11, came with this PR.

Check List

• All tests pass
• Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Merging #356 (6f78c6e) into main (67ced0d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #356      +/-   ##
============================================
+ Coverage     84.56%   84.57%   +0.01%     
  Complexity      427      427              
============================================
  Files            35       35              
  Lines          1289     1290       +1     
  Branches        189      189              
============================================
+ Hits           1090     1091       +1     
  Misses          118      118              
  Partials         81       81              

Files	Coverage Δ
...lsearch/search/query/HybridQueryPhaseSearcher.java	71.76% <100.00%> (+0.33%)	⬆️

[vamshin]

LGTM! Thanks

[navneet1v]

@martin-gaievski should we have a check with concurrent segment search enabled? what do you think?

[martin-gaievski]

@martin-gaievski should we have a check with concurrent segment search enabled? what do you think?

we definitely need to check that, do you mean check manually or add a test for this?

[heemin32]

@martin-gaievski should we have a check with concurrent segment search enabled? what do you think?

I believe, it should be safe to assume that concurrent search is disabled.

[navneet1v]

@martin-gaievski should we have a check with concurrent segment search enabled? what do you think?

we definitely need to check that, do you mean check manually or add a test for this?

The thing is concurrent search is not GA, I think we can skip for now. But Last when I checked by enabling the concurrent search our tests failed. Now I am hoping when concurrent search will become GA they will ask all plugins to validate.