Add validations from appsec #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/reranker #562 +/- ##
======================================================
- Coverage 84.70% 84.43% -0.27%
- Complexity 600 603 +3
======================================================
Files 48 48
Lines 1804 1825 +21
Branches 272 275 +3
======================================================
+ Hits 1528 1541 +13
- Misses 155 161 +6
- Partials 121 123 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
HenryL27
force-pushed
the
feature/reranker
branch
from
3fe935c
to
9a6fe41
Compare
HenryL27
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
...ain/java/org/opensearch/neuralsearch/processor/rerank/context/QueryContextSourceFetcher.java
Outdated
Show resolved
Hide resolved
martin-gaievski
changed the title
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
...ain/java/org/opensearch/neuralsearch/processor/rerank/context/QueryContextSourceFetcher.java
Outdated
Show resolved
Hide resolved
Signed-off-by: HenryL27 <[email protected]>
...ain/java/org/opensearch/neuralsearch/processor/rerank/context/QueryContextSourceFetcher.java
Outdated
Show resolved
Hide resolved
martin-gaievski
approved these changes
Jan 29, 2024
Signed-off-by: HenryL27 <[email protected]>
|
Could you add which validations is this PR added in the description? |
heemin32
reviewed
Jan 30, 2024
...test/java/org/opensearch/neuralsearch/processor/rerank/MLOpenSearchRerankProcessorTests.java
Outdated
Show resolved
Hide resolved
| public void textRerankContext_whenQueryTextPathIsExceeedinglyDeeplyNested_ThenFail() throws IOException { | ||
| setupParams(Map.of(QueryContextSourceFetcher.QUERY_TEXT_PATH_FIELD, "a.b.c.d.e.f.g.h.i.j.k.l.m.n.o.p.q.r.s.t.w.x.y.z")); | ||
| setupSearchResults(); | ||
| @SuppressWarnings("unchecked") |
There was a problem hiding this comment.
Why do we need this annotation? I don't see ActionListener<Map<String, Object>> listener = mock(ActionListener.class); is causing any warning in my local.
There was a problem hiding this comment.
¯_(ツ)_/¯. I get a warning when I remove it. Makes sense since it's a typecast from generic action listener to action listener for that map thingy.
...test/java/org/opensearch/neuralsearch/processor/rerank/MLOpenSearchRerankProcessorTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/processor/factory/RerankProcessorFactoryTests.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/neuralsearch/processor/rerank/context/DocumentContextSourceFetcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/factory/RerankProcessorFactory.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Heemin Kim <[email protected]> Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
heemin32
approved these changes
Jan 31, 2024
martin-gaievski
merged commit d21d838
into
opensearch-project:feature/reranker
57 of 59 checks passed
|
@martin-gaievski do we need to backport this? |
|
Yes, it will be backported later, along with other PRs for this feature. Idea is that all changes go to feature branch, once all steps are finalized it's merged to main in a separate PR and then backported from there to other branches like 2.x. |
|
oh right, forgot this was on a feature branch lol |
martin-gaievski
pushed a commit
to martin-gaievski/neural-search
that referenced
this pull request
Feb 6, 2024
* add validations from appsec Signed-off-by: HenryL27 <[email protected]> Co-authored-by: Heemin Kim <[email protected]>
martin-gaievski
pushed a commit
that referenced
this pull request
Feb 6, 2024
* add validations from appsec Signed-off-by: HenryL27 <[email protected]> Co-authored-by: Heemin Kim <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding validation for parameters of re-ranker processor.
Issues Resolved
#555
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.