Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build.gradle to excludes neural_query_enricher neural sparse search in testRollingUpgrade #638

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

zhichao-aws
Copy link
Member

Description

In #614 we support neural sparse search in neural_query_enricher. We also add bwc test for this feature. In the build.gradle file for bwc tests, we exclude the tests for this feature for bwc version before 2.13.

But in #614 we missed one place where we should do update (:qa:rolling-upgrade testRollingUpgrade). In this PR we update the excludes logic here.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: zhichao-aws <[email protected]>
@zhichao-aws
Copy link
Member Author

We don't need backport this PR. The content is included in #637

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (e41fba7) to head (f31c82b).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #638   +/-   ##
=========================================
  Coverage     82.62%   82.62%           
  Complexity      666      666           
=========================================
  Files            52       52           
  Lines          2072     2072           
  Branches        334      334           
=========================================
  Hits           1712     1712           
  Misses          212      212           
  Partials        148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zane-neo zane-neo merged commit fcb80a3 into opensearch-project:main Mar 14, 2024
75 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants