enhancements: support neural_sparse query by tokens #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhichao-aws
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es and
vibrantvarun
as code owners
zhichao-aws
added
v2.14.0
Enhancements
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
chishui
reviewed
Apr 18, 2024
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Show resolved
Hide resolved
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
force-pushed
the
query_by_tokens
branch
from
863868f
to
fb771cd
Compare
chishui
reviewed
Apr 19, 2024
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Outdated
Show resolved
Hide resolved
zane-neo
reviewed
Apr 19, 2024
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Show resolved
Hide resolved
Signed-off-by: zhichao-aws <[email protected]>
zane-neo
approved these changes
Apr 19, 2024
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
chishui
approved these changes
Apr 22, 2024
8 tasks
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Show resolved
Hide resolved
model-collapse
approved these changes
Apr 22, 2024
zhichao-aws
added
the
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
* enhancements: support neural sparse query by tokens Signed-off-by: zhichao-aws <[email protected]> * add empty string logics for streams Signed-off-by: zhichao-aws <[email protected]> * fix fromXContent error case logic Signed-off-by: zhichao-aws <[email protected]> * add ut Signed-off-by: zhichao-aws <[email protected]> * ut it Signed-off-by: zhichao-aws <[email protected]> * updates for comments Signed-off-by: zhichao-aws <[email protected]> * nit Signed-off-by: zhichao-aws <[email protected]> * fix comments Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit f5a47a6)
zhichao-aws
added a commit
that referenced
this pull request
Apr 22, 2024
* enhancements: support neural sparse query by tokens Signed-off-by: zhichao-aws <[email protected]> * add empty string logics for streams Signed-off-by: zhichao-aws <[email protected]> * fix fromXContent error case logic Signed-off-by: zhichao-aws <[email protected]> * add ut Signed-off-by: zhichao-aws <[email protected]> * ut it Signed-off-by: zhichao-aws <[email protected]> * updates for comments Signed-off-by: zhichao-aws <[email protected]> * nit Signed-off-by: zhichao-aws <[email protected]> * fix comments Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit f5a47a6) Co-authored-by: zhichao-aws <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support raw tokens query in neural_sparse search
Issues Resolved
#608
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.