Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for cluster status call in BWC #892

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Sep 5, 2024

Description

Increase timeout for wait_for_green_status call for BWC rolling upgrade tests. Increase from default 30s to 60s.

Related Issues

Flaky BWC tests in CI. Caused errors like here: https://github.com/opensearch-project/neural-search/actions/runs/10713784342/job/29706410196?pr=886

org.opensearch.client.ResponseException: method [GET], host [http://127.0.0.1:32775/], URI [/_cluster/health?wait_for_nodes=3&wait_for_status=green], status line [HTTP/1.1 408 Request Timeout]
    {"cluster_name":"neuralSearchBwcCluster-rolling","status":"yellow","timed_out":true,"number_of_nodes":3,"number_of_data_nodes":3,"discovered_master":true,"discovered_cluster_manager":true,"active_primary_shards":25,"active_shards":49,"relocating_shards":0,"initializing_shards":0,"unassigned_shards":1,"delayed_unassigned_shards":1,"number_of_pending_tasks":0,"number_of_in_flight_fetch":0,"task_max_waiting_in_queue_millis":0,"active_shards_percent_as_number":98.0}
        at __randomizedtesting.SeedInfo.seed([12431F7E983230AD:BBF02D70ED1EF549]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:479)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:371)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:346)
        at app//org.opensearch.neuralsearch.BaseNeuralSearchIT.waitForClusterHealthGreen(BaseNeuralSearchIT.java:1197)
        at app//org.opensearch.neuralsearch.bwc.HybridSearchIT.testNormalizationProcessor_whenIndexWithMultipleShards_E2EFlow(HybridSearchIT.java:40)

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vibrantvarun vibrantvarun merged commit 22f36c5 into opensearch-project:2.17 Sep 5, 2024
144 checks passed
@vibrantvarun vibrantvarun added backport 2.x Label will add auto workflow to backport PR to 2.x branch backport 2.17 labels Sep 5, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 22f36c5)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-892-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 22f36c5f4f44d8efcd346f3cb7b40790e69dc4c8
# Push it to GitHub
git push --set-upstream origin backport/backport-892-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-892-to-2.17.

@naveentatikonda
Copy link
Member

@martin-gaievski Let us observe the BWC Tests checks for 2.x and 2.17. I saw them failing mostly there

@vibrantvarun
Copy link
Member

@martin-gaievski can you raise manual PR for 2.17?

@martin-gaievski
Copy link
Member Author

martin-gaievski commented Sep 5, 2024

this is for 2.17, I need to upport it to main and 2.x.
Sorry, I took a shortcut and started from 2.17 directly :)

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 22f36c5)
vibrantvarun pushed a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 22f36c5)

Co-authored-by: Martin Gaievski <[email protected]>
vibrantvarun pushed a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 22f36c5)

Co-authored-by: Martin Gaievski <[email protected]>
martin-gaievski added a commit to Johnsonisaacn/neural-search that referenced this pull request Oct 11, 2024
…) (opensearch-project#894)

Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 22f36c5)

Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main backport 2.x Label will add auto workflow to backport PR to 2.x branch Infrastructure skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants