Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cve issues related to logback #1791

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

Conversation

YANG-DB
Copy link
Member

@YANG-DB YANG-DB commented Feb 5, 2024

Description

fix cve issues related to logback

Issues Resolved

#1780

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@YANG-DB YANG-DB self-assigned this Feb 5, 2024
@YANG-DB YANG-DB added the security fix Security fix generated by WhiteSource label Feb 6, 2024
@YANG-DB YANG-DB added the feature label Feb 6, 2024
@joshuali925
Copy link
Member

CI failed

Execution failed for task ':ktlint'.
> Could not resolve all dependencies for configuration ':ktlint'.
   > Conflict found for the following module:
       - org.slf4j:slf4j-api between versions 2.0.0 and 1.7.32

@sejli
Copy link
Member

sejli commented Feb 6, 2024

Full scan here

Dependency resolution failed because of conflict on the following module:
   - org.slf4j:slf4j-api between versions 2.0.0 and 1.7.32

org.slf4j:slf4j-api:2.0.0
  Variant runtime:
    | Attribute Name             | Provided     | Requested |
    |----------------------------|--------------|-----------|
    | org.gradle.category        | library      |           |
    | org.gradle.libraryelements | jar          |           |
    | org.gradle.status          | release      |           |
    | org.gradle.usage           | java-runtime |           |
   Selection reasons:
      - By conflict resolution: between versions 2.0.0 and 1.7.32

org.slf4j:slf4j-api:2.0.0
\--- ch.qos.logback:logback-classic:1.3.0
     \--- com.pinterest:ktlint:0.47.1
          \--- ktlint

org.slf4j:slf4j-api:1.7.32 -> 2.0.0
\--- io.github.microutils:kotlin-logging-jvm:2.1.23
     +--- com.pinterest.ktlint:ktlint-ruleset-standard:0.47.1
     |    \--- com.pinterest:ktlint:0.47.1
     |         \--- ktlint
     \--- com.pinterest.ktlint:ktlint-core:0.47.1
          +--- com.pinterest:ktlint:0.47.1 (*)
          +--- com.pinterest.ktlint:ktlint-reporter-baseline:0.47.1
          |    \--- com.pinterest:ktlint:0.47.1 (*)
          +--- com.pinterest.ktlint:ktlint-reporter-checkstyle:0.47.1
          |    \--- com.pinterest:ktlint:0.47.1 (*)
          +--- com.pinterest.ktlint:ktlint-reporter-json:0.47.1
          |    \--- com.pinterest:ktlint:0.47.1 (*)
          +--- com.pinterest.ktlint:ktlint-reporter-format:0.47.1
          |    \--- com.pinterest:ktlint:0.47.1 (*)
          +--- com.pinterest.ktlint:ktlint-reporter-html:0.47.1
          |    \--- com.pinterest:ktlint:0.47.1 (*)
          +--- com.pinterest.ktlint:ktlint-reporter-plain:0.47.1
          |    \--- com.pinterest:ktlint:0.47.1 (*)
          +--- com.pinterest.ktlint:ktlint-reporter-sarif:0.47.1
          |    \--- com.pinterest:ktlint:0.47.1 (*)
          +--- com.pinterest.ktlint:ktlint-ruleset-experimental:0.47.1
          |    \--- com.pinterest:ktlint:0.47.1 (*)
          +--- com.pinterest.ktlint:ktlint-ruleset-standard:0.47.1 (*)
          \--- com.pinterest.ktlint:ktlint-ruleset-test:0.47.1
               \--- com.pinterest:ktlint:0.47.1 (*)

(*) - Indicates repeated occurrences of a transitive dependency subtree. Gradle expands transitive dependency subtrees only once per project; repeat occurrences only display the root of the subtree, followed by this annotation.

@ps48
Copy link
Member

ps48 commented Feb 6, 2024

Added backport 2.12 label as the branch is cut for build team to proceed with RC today.
@YANG-DB Can you please make sure after gradle issue is fixed, we backport this to 2.12?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants