Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _source accepting an array of fields in _search. #430

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 17, 2024

Description

Coming from opensearch-project/opensearch-java#1087, _source accepts an array of fields in _search. Looks like we also don't properly document this in https://opensearch.org/docs/latest/api-reference/search.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Jul 17, 2024

Changes Analysis

Commit SHA: 49817b1
Comparing To SHA: 82c000f

API Changes

Summary


└─┬Components
  └─┬_core.search:SourceConfig
    ├──[➕] oneOf (38360:11)
    ├─┬ONEOF
    │ └──[🔀] $ref (38361:11)❌ 
    └─┬ONEOF
      └──[🔀] $ref (38373:13)❌ 

Document Element Total Changes Breaking Changes
components 3 2
  • BREAKING Changes: 2 out of 3
  • Modifications: 2
  • Additions: 1
  • Breaking Modifications: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9977843973/artifacts/1711603133

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@nhtruong nhtruong merged commit e1cd369 into opensearch-project:main Jul 18, 2024
12 checks passed
@dblock dblock deleted the search-source-filter branch July 18, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants