Implement a basic Jenkins job for running OpenSearch Dashboards integ test #1368

tianleh · 2021-12-17T11:15:43Z

Description

It sets up the basic structure as incremental progress including the input parameters and test execution. It may still need more features like uploading testing results which I plan to do as follow ups. Eventually this job will be called post bundle build job.

Issues Resolved

resolves #1322

Test

A successful run http://jenki-jenki-fpgmrv2ryxko-1366042710.us-east-1.elb.amazonaws.com/job/test-osd-tianleh/11/

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tianle Huang <[email protected]>

tianleh · 2021-12-17T11:17:53Z

Screenshots of the sample run

codecov-commenter · 2021-12-17T11:17:55Z

Codecov Report

Merging #1368 (99fee2d) into main (59b954c) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1368      +/-   ##
============================================
+ Coverage     93.94%   94.02%   +0.07%     
  Complexity       11       11              
============================================
  Files           136      138       +2     
  Lines          2974     3013      +39     
  Branches          8        8              
============================================
+ Hits           2794     2833      +39     
  Misses          172      172              
  Partials          8        8

Impacted Files	Coverage Δ
src/build_workflow/build_args.py	`100.00% <0.00%> (ø)`
src/build_workflow/build_target.py	`100.00% <0.00%> (ø)`
src/build_workflow/build_recorder.py	`100.00% <0.00%> (ø)`
src/build_workflow/builder_from_source.py	`100.00% <0.00%> (ø)`
src/build_workflow/build_artifact_checks.py	`100.00% <0.00%> (ø)`
.../jenkins/jobs/PromoteArtifacts_actions_Jenkinsfile	`100.00% <0.00%> (ø)`
tests/jenkins/jobs/PromoteArtifacts_Jenkinsfile	`100.00% <0.00%> (ø)`
src/system/properties_file.py	`97.43% <0.00%> (+0.06%)`	⬆️
...ensearch_dashboards/build_artifact_check_plugin.py	`96.55% <0.00%> (+0.12%)`	⬆️
..._workflow/opensearch/build_artifact_check_maven.py	`95.65% <0.00%> (+0.19%)`	⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b954c...99fee2d. Read the comment docs.

seraphjiang · 2021-12-17T14:20:49Z

jenkins/opensearch-dashboards/integ-test-opensearch-dashboards.jenkinsfile

@@ -0,0 +1,83 @@
+lib = library(identifier: 'jenkins@20211123', retriever: legacySCM(scm))


What is this identifier, why use fixed date value?

Jenkins caches the library sometimes, so when we make code changes we tend to increment this everywhere.

seraphjiang · 2021-12-17T14:27:24Z

jenkins/opensearch-dashboards/integ-test-opensearch-dashboards.jenkinsfile

+            node('Jenkins-Agent-al2-x64-c54xlarge-Docker-Host') {
+                script {
+                    postCleanup()
+                }
+            }


Could we define function

https://stackoverflow.com/questions/42158539/how-to-define-and-use-function-inside-jenkins-pipeline-config

Could always cover?

https://www.jenkins.io/doc/pipeline/tour/post/

I wasn't able to extract the whole post part with tests.

jenkins/opensearch-dashboards/integ-test-opensearch-dashboards.jenkinsfile

Signed-off-by: Tianle Huang <[email protected]>

tianleh · 2021-12-18T21:36:00Z

Latest run is successful. http://jenki-jenki-fpgmrv2ryxko-1366042710.us-east-1.elb.amazonaws.com/job/Playground/job/test-osd-tianleh/

tianleh · 2021-12-18T21:37:40Z

Please help take a look again when available @dblock @peternied

tianleh · 2021-12-18T23:05:30Z

Created a Github issue to support arm64 #1381

peternied

Paths are still being computed, take a full path to as input, its simple and lets the caller have control to execute any kind of combination of sources they see fit

When I consider the functionality I think the job parameters at most need to be the following:

the path to the test manifest file, relative position in the OpenSearch-Build repository
the path to the opensearch distribution manifest file
the path to the opensearch-dashboards distribution manifest file

Any other values can be inferred from those files after they've been inspected. If there is more information that is needed then we should see about putting it in the test manifest file as that should describe how to execute the tests.

peternied · 2021-12-19T00:20:52Z

jenkins/opensearch-dashboards/integ-test-opensearch-dashboards.jenkinsfile

+                        version: opensearch_dashboards_version
+                    )
+
+                    sh "./test.sh integ-test manifests/${opensearch_dashboards_version}/opensearch-dashboards-${opensearch_dashboards_version}-test.yml -p opensearch=${basePathOpenSearch} opensearch-dashboards=${basePathOpenSearchDashboards} --test-run-id ${env.BUILD_NUMBER}"


Lets just pass the test manifest path, this is forward compatible with path changes

Suggested change

sh "./test.sh integ-test manifests/${opensearch_dashboards_version}/opensearch-dashboards-${opensearch_dashboards_version}-test.yml -p opensearch=${basePathOpenSearch} opensearch-dashboards=${basePathOpenSearchDashboards} --test-run-id ${env.BUILD_NUMBER}"

sh "./test.sh integ-test ${TEST-MANIFEST} -p opensearch=${basePathOpenSearch} opensearch-dashboards=${basePathOpenSearchDashboards} --test-run-id ${env.BUILD_NUMBER}"

abhinavGupta16

Let's add test cases for both the files that added -

vars/getPublicUrl.groovy
jenkins/opensearch-dashboards/integ-test-opensearch-dashboards.jenkinsfile

dblock · 2022-01-11T12:39:50Z

jenkins/opensearch-dashboards/integ-test-opensearch-dashboards.jenkinsfile

+            name: 'platform',
+            description: 'Platform of the build of OpenSearch/OpenSearch Dashboards',
+            trim: true
+        )


I would prefer if the parameters to this job was 1) an OpenSearch Dashboards build URL (e.g. ci.opensearch....) that contains a manifest that would get loaded and all these features such as build ID and architecture and platform were to be extracted, and 2) an OpenSearch URL. Otherwise we keep building assumptions in the URL structure of where things are built, ie. this job "knows" something it shouldn't about the location of builds. Then this code loads the manifest(s) and has everything it needs, it would be shorter and easier to grok.

Use CAPS for variables similarly to other Jenkinsfile.

tianleh · 2022-01-15T01:02:25Z

will work on this issue #1482 first so that the release url has the same substructure similar to regular distribution url

tianleh · 2022-01-18T20:12:58Z

Tried to add builds/dist in #1490 However, we may need an alternative approach.

tianleh · 2022-01-27T07:38:29Z

Need to complete this pre-requested issue first #1492

tianleh · 2022-02-19T19:53:16Z

This work is switched to #1653

tianleh added 9 commits December 17, 2021 10:04

Add Jenkins job for Dashboards integ test

70539ae

Signed-off-by: Tianle Huang <[email protected]>

remove unneeded

322920d

Signed-off-by: Tianle Huang <[email protected]>

add dashboards manifest

dba0dc2

Signed-off-by: Tianle Huang <[email protected]>

set docker

5427288

Signed-off-by: Tianle Huang <[email protected]>

use bundle build skeleton

f3d22d0

Signed-off-by: Tianle Huang <[email protected]>

simplify

44524e2

Signed-off-by: Tianle Huang <[email protected]>

remove unneeded stage

68f611d

Signed-off-by: Tianle Huang <[email protected]>

remove docker

b7cff49

Signed-off-by: Tianle Huang <[email protected]>

remove wget

abcb17e

Signed-off-by: Tianle Huang <[email protected]>

tianleh requested a review from a team as a code owner December 17, 2021 11:15

tianleh requested review from dblock, peterzhuamazon, seraphjiang and kavilla December 17, 2021 11:15

tianleh requested a review from peternied December 17, 2021 11:18

tianleh self-assigned this Dec 17, 2021

tianleh added the ci-test-automation label Dec 17, 2021

tianleh requested review from sichend and Tengda-He December 17, 2021 11:20

seraphjiang approved these changes Dec 17, 2021

View reviewed changes

peternied suggested changes Dec 17, 2021

View reviewed changes

jenkins/opensearch-dashboards/integ-test-opensearch-dashboards.jenkinsfile Outdated Show resolved Hide resolved

tianleh added 7 commits December 18, 2021 20:46

use BuildManifest to get public url

b3b0884

Signed-off-by: Tianle Huang <[email protected]>

add import of lib

3ef367c

Signed-off-by: Tianle Huang <[email protected]>

fix No such DSL method

811578d

Signed-off-by: Tianle Huang <[email protected]>

change input to map

eb60751

Signed-off-by: Tianle Huang <[email protected]>

fix syntax

5fa90a7

Signed-off-by: Tianle Huang <[email protected]>

fix

989af3a

Signed-off-by: Tianle Huang <[email protected]>

update input style

e36b524

Signed-off-by: Tianle Huang <[email protected]>

pass version

99fee2d

Signed-off-by: Tianle Huang <[email protected]>

tianleh requested a review from peternied December 18, 2021 21:36

peternied suggested changes Dec 19, 2021

View reviewed changes

abhinavGupta16 suggested changes Jan 10, 2022

View reviewed changes

dblock requested changes Jan 11, 2022

View reviewed changes

tianleh mentioned this pull request Jan 12, 2022

Run Dashboards integ test against static endpoint in Jenkins job #1322

Closed

tianleh marked this pull request as draft January 27, 2022 07:39

tianleh closed this Feb 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement a basic Jenkins job for running OpenSearch Dashboards integ test #1368

Implement a basic Jenkins job for running OpenSearch Dashboards integ test #1368

tianleh commented Dec 17, 2021

tianleh commented Dec 17, 2021

codecov-commenter commented Dec 17, 2021 •

edited

Loading

seraphjiang Dec 17, 2021

dblock Dec 17, 2021

seraphjiang Dec 17, 2021

seraphjiang Dec 17, 2021

dblock Dec 17, 2021 •

edited

Loading

tianleh commented Dec 18, 2021

tianleh commented Dec 18, 2021

tianleh commented Dec 18, 2021 •

edited

Loading

peternied left a comment

peternied Dec 19, 2021

abhinavGupta16 left a comment •

edited

Loading

dblock Jan 11, 2022 •

edited

Loading

tianleh commented Jan 15, 2022

tianleh commented Jan 18, 2022

tianleh commented Jan 27, 2022

tianleh commented Feb 19, 2022

		@@ -0,0 +1,83 @@
		lib = library(identifier: 'jenkins@20211123', retriever: legacySCM(scm))

	sh "./test.sh integ-test manifests/${opensearch_dashboards_version}/opensearch-dashboards-${opensearch_dashboards_version}-test.yml -p opensearch=${basePathOpenSearch} opensearch-dashboards=${basePathOpenSearchDashboards} --test-run-id ${env.BUILD_NUMBER}"
	sh "./test.sh integ-test ${TEST-MANIFEST} -p opensearch=${basePathOpenSearch} opensearch-dashboards=${basePathOpenSearchDashboards} --test-run-id ${env.BUILD_NUMBER}"

Implement a basic Jenkins job for running OpenSearch Dashboards integ test #1368

Implement a basic Jenkins job for running OpenSearch Dashboards integ test #1368

Conversation

tianleh commented Dec 17, 2021

Description

Issues Resolved

Test

Check List

tianleh commented Dec 17, 2021

codecov-commenter commented Dec 17, 2021 • edited Loading

Codecov Report

seraphjiang Dec 17, 2021

Choose a reason for hiding this comment

dblock Dec 17, 2021

Choose a reason for hiding this comment

seraphjiang Dec 17, 2021

Choose a reason for hiding this comment

seraphjiang Dec 17, 2021

Choose a reason for hiding this comment

dblock Dec 17, 2021 • edited Loading

Choose a reason for hiding this comment

tianleh commented Dec 18, 2021

tianleh commented Dec 18, 2021

tianleh commented Dec 18, 2021 • edited Loading

peternied left a comment

Choose a reason for hiding this comment

peternied Dec 19, 2021

Choose a reason for hiding this comment

abhinavGupta16 left a comment • edited Loading

Choose a reason for hiding this comment

dblock Jan 11, 2022 • edited Loading

Choose a reason for hiding this comment

tianleh commented Jan 15, 2022

tianleh commented Jan 18, 2022

tianleh commented Jan 27, 2022

tianleh commented Feb 19, 2022

codecov-commenter commented Dec 17, 2021 •

edited

Loading

dblock Dec 17, 2021 •

edited

Loading

tianleh commented Dec 18, 2021 •

edited

Loading

abhinavGupta16 left a comment •

edited

Loading

dblock Jan 11, 2022 •

edited

Loading