Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AD from manifest to get job-scheduler SPI uploaded to maven. #1462

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Jan 13, 2022

Signed-off-by: dblock [email protected]

Description

We have a chicken-egg problem where without building a successful distribution we don't get a job-scheduler-spi in maven, see #1463. This is blocking opensearch-project/anomaly-detection#360.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from a team as a code owner January 13, 2022 15:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #1462 (348ce04) into main (3f74bc2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1462   +/-   ##
=========================================
  Coverage     94.45%   94.45%           
  Complexity       12       12           
=========================================
  Files           141      141           
  Lines          3084     3084           
  Branches          8        8           
=========================================
  Hits           2913     2913           
  Misses          164      164           
  Partials          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f74bc2...348ce04. Read the comment docs.

@dblock dblock merged commit 7fada0b into opensearch-project:main Jan 13, 2022
@dblock dblock deleted the remove-anomaly-detection branch January 13, 2022 17:24
@dblock dblock mentioned this pull request Jan 13, 2022
1 task
peterzhuamazon pushed a commit to peterzhuamazon/opensearch-build that referenced this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants