updated promote artifacts lib s3 upload

[abhinavGupta16]

Signed-off-by: Abhinav Gupta [email protected]

Description

Remove s3 upload to builds and dist directly from promoteArtifacts.groovy

Issues Resolved

Remove stray artifacts from release folder

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

@abhinavGupta16 Care to explain in the PR description why adding this was a bad idea, please?

[tianleh]

@abhinavGupta16 Care to explain in the PR description why adding this was a bad idea, please?

Thanks @abhinavGupta16 for the quick fix.

A bit context: I added the logic to upload builds/dist under releases url during the tar-promotion job as part of the following PR
#1490 with the intention to let Dashboards integ test run against a static OpenSearch url.

However, the tar-promotion job https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/promotion/tar-promotion.jenkinsfile only runs once manually during release meeting. Thus the url won't be ready (which also means that the Dashboards integ test won't get the OpenSearch url) until the last minute.

A better option would be uploading such builds/dist in a periodic automatic job, e.g the distribution build job. Also since this build will be ongoing and is not actual release artifacts, we can consider uploading to release-candidates url.

[tianleh]

@abhinavGupta16 Care to explain in the PR description why adding this was a bad idea, please?

Thanks @abhinavGupta16 for the quick fix.

A bit context: I added the logic to upload builds/dist under releases url during the tar-promotion job as part of the following PR #1490 with the intention to let Dashboards integ test run against a static OpenSearch url.

However, the tar-promotion job https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/promotion/tar-promotion.jenkinsfile only runs once manually during release meeting. Thus the url won't be ready (which also means that the Dashboards integ test won't get the OpenSearch url) until the last minute.

A better option would be uploading such builds/dist in a periodic automatic job, e.g the distribution build job. Also since this build will be ongoing and is not actual release artifacts, we can consider uploading to release-candidates url.

@dblock Let me know if this summary is enough.

[dblock]

A better option would be uploading such builds/dist in a periodic automatic job, e.g the distribution build job. Also since this build will be ongoing and is not actual release artifacts, we can consider uploading to release-candidates url.

I think #1492 can solve this in a way where "latest" = latest released or latest build.