-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix failed jest by unifying cdk versions #1675
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1675 +/- ##
============================================
+ Coverage 94.59% 94.62% +0.02%
Complexity 14 14
============================================
Files 159 164 +5
Lines 3387 3459 +72
Branches 7 21 +14
============================================
+ Hits 3204 3273 +69
- Misses 180 183 +3
Partials 3 3
Continue to review full report at Codecov.
|
|
Local is working but Github action is failing. |
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix here! Have you tried if the latest version of aws-cdk v1.146.0 works for this?
The 1.145 version is chosen to be parity with others https://github.com/opensearch-project/opensearch-build/blob/main/deployment/package.json#L31 We can explore more updates later. |
@zelinh please help take a look when available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Link to main issue #1492 |
Signed-off-by: Tianle Huang [email protected]
Description
Fix https://github.com/opensearch-project/opensearch-build/runs/5341305055?check_suite_focus=true
Follow up of #1660
Issues Resolved
https://github.com/opensearch-project/opensearch-build/runs/5341305055?check_suite_focus=true
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.