replace ci prefix only at rewriting part

[tianleh]

Signed-off-by: Tianle Huang [email protected]

Description

We observed that https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.0/latest/linux/arm64/builds/opensearch/manifest.yml
is being redirected to
https://ci.opensearch.org/distribution-build-opensearch/1.3.0/1204/linux/arm64/builds/opensearch/manifest.yml

and ended up with AccessDenied error. Thus we shall not remove ci/dbc during redirect. Instead, it shall only happen at the rewrite part.

Issues Resolved

Test

update unit test for this.

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #1681 (b6a6c0f) into main (9cb1ffb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1681   +/-   ##
=========================================
  Coverage     94.74%   94.74%           
  Complexity       14       14           
=========================================
  Files           166      166           
  Lines          3501     3501           
  Branches         25       25           
=========================================
  Hits           3317     3317           
  Misses          181      181           
  Partials          3        3           

Impacted Files	Coverage Δ
...loyment/lambdas/cf-url-rewriter/cf-url-rewriter.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb1ffb...b6a6c0f. Read the comment docs.

[peternied]

Could there be a missing test case that can be added? I'm not certain from the current logic if all scenarios are getting coverage.

[tianleh]

Could there be a missing test case that can be added? I'm not certain from the current logic if all scenarios are getting coverage.

Thought about this as well. The underlying issue is that the url without ci/dbc ( https://ci.opensearch.org/distribution-build-opensearch/1.3.0/1204/linux/arm64/builds/opensearch/manifest.yml) doesn't work. I could create a follow up issue to see how we can gate such. Or I can add a unit test to ensure that the url must contain ci/dbc?

[tianleh]

Could there be a missing test case that can be added? I'm not certain from the current logic if all scenarios are getting coverage.

Added checks and related unit tests for such. Please help take a look. @peternied

[tianleh]

-----------------------------|---------|----------|---------|---------|-------------------
File                         | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-----------------------------|---------|----------|---------|---------|-------------------
All files                    |     100 |      100 |     100 |     100 |                   
 lambdas/cf-url-rewriter     |     100 |      100 |     100 |     100 |                   
  cf-url-rewriter.ts         |     100 |      100 |     100 |     100 |                   
  https-get.ts               |     100 |      100 |     100 |     100 |                   
 lib                         |     100 |      100 |     100 |     100 |                   
  artifacts-public-access.ts |     100 |      100 |     100 |     100 |                   
  buckets.ts                 |     100 |      100 |     100 |     100 |                   
  build-artifact-stack.ts    |     100 |      100 |     100 |     100 |                   
  identities.ts              |     100 |      100 |     100 |     100 |                   
-----------------------------|---------|----------|---------|---------|-------------------

Test Suites: 3 passed, 3 total
Tests:       13 passed, 13 total
Snapshots:   0 total
Time:        3.3 s

[gaiksaya]

Hi @tianleh, the new changes are deployed. Please check.

Thanks!

[gaiksaya]

Tried the below URLs:
https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.0/latest/linux/x64/builds/opensearch/manifest.yml
https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.0/latest/linux/arm64/builds/opensearch/manifest.yml

Looks like its working 🥳

[tianleh]

Link to main issue #1492