Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifier for PA build.sh and remove RCA one #1940

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Description

Add qualifier for PA build.sh and remove RCA one

Issues Resolved

#1632

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon self-assigned this Apr 7, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner April 7, 2022 23:24
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #1940 (0e2eac8) into main (9a8966c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1940   +/-   ##
=========================================
  Coverage     94.60%   94.60%           
  Complexity       20       20           
=========================================
  Files           178      178           
  Lines          3633     3633           
  Branches         27       27           
=========================================
  Hits           3437     3437           
  Misses          192      192           
  Partials          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8966c...0e2eac8. Read the comment docs.

@peterzhuamazon
Copy link
Member Author

When building PA then RCA will be built as well.
So no need to include a RCA specific script.
Thanks.

@peterzhuamazon peterzhuamazon merged commit 91d0a57 into opensearch-project:main Apr 7, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-PA-fix branch April 7, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants