Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a License header Checker #2666

Merged
merged 10 commits into from
Sep 28, 2022
Merged

Conversation

Divyaasm
Copy link
Collaborator

Description

-Created a workflow to to check for Header Licenses in files.
-Added license Header for files missing them.
-Updated files include - " python,groovy,js,ts,sh "

Issues Resolved

Workflow checks for the presence of Header License on push and pull requests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
@Divyaasm Divyaasm requested a review from a team as a code owner September 27, 2022 20:53
vars/archiveAssembleUpload.groovy Outdated Show resolved Hide resolved
@prudhvigodithi
Copy link
Collaborator

Hey @Divyaasm qq, will the License header Checker, check's the entire following lines?

/*
* Copyright OpenSearch Contributors  
* SPDX-License-Identifier: Apache-2.0
* 
* The OpenSearch Contributors require contributions made to
* this file be licensed under the Apache-2.0 license or a
* compatible open source license.
*/

or just Copyright OpenSearch Contributors and SPDX-License-Identifier: Apache-2.0 based on the file .licenserc.json

@Divyaasm
Copy link
Collaborator Author

Hey @Divyaasm qq, will the License header Checker, check's the entire following lines?

/*
* Copyright OpenSearch Contributors  
* SPDX-License-Identifier: Apache-2.0
* 
* The OpenSearch Contributors require contributions made to
* this file be licensed under the Apache-2.0 license or a
* compatible open source license.
*/

or just Copyright OpenSearch Contributors and SPDX-License-Identifier: Apache-2.0 based on the file .licenserc.json

It checks for the two lines Copyright OpenSearch Contributors and SPDX-License-Identifier: Apache-2.0. Barani recommended that these are the lines that are necessary. So, I've opted them.

@prudhvigodithi
Copy link
Collaborator

prudhvigodithi commented Sep 27, 2022

It checks for the two lines Copyright OpenSearch Contributors and SPDX-License-Identifier: Apache-2.0. Barani recommended that these are the lines that are necessary. So, I've opted them.

Got it thanks @Divyaasm , but I believe the entire sentence should be part of license check?

Copyright OpenSearch Contributors  
SPDX-License-Identifier: Apache-2.0

The OpenSearch Contributors require contributions made to
this file be licensed under the Apache-2.0 license or a
compatible open source license.

From Core https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/src/main/java/org/opensearch/gradle/pluginzip/Publish.java#L1-L7
@gaiksaya @peterzhuamazon @bbarani

@bbarani
Copy link
Member

bbarani commented Sep 27, 2022

Copyright OpenSearch Contributors
SPDX-License-Identifier: Apache-2.0

@prudhvigodithi We ran a campaign last year and used the 2 liner license text as mentioned here. @dblock Do you have any feedback on this license text?

@bbarani bbarani requested a review from dblock September 27, 2022 22:30
Signed-off-by: Divya Madala <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #2666 (ba549fe) into main (3685352) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2666   +/-   ##
=========================================
  Coverage     93.94%   93.94%           
  Complexity       28       28           
=========================================
  Files           219      219           
  Lines          4494     4494           
  Branches         29       29           
=========================================
  Hits           4222     4222           
  Misses          266      266           
  Partials          6        6           
Impacted Files Coverage Δ
...loyment/lambdas/cf-url-rewriter/cf-url-rewriter.ts 100.00% <ø> (ø)
deployment/lambdas/cf-url-rewriter/https-get.ts 100.00% <ø> (ø)
deployment/lib/artifacts-public-access.ts 100.00% <ø> (ø)
deployment/lib/buckets.ts 100.00% <ø> (ø)
deployment/lib/build-artifact-stack.ts 100.00% <ø> (ø)
deployment/lib/identities.ts 100.00% <ø> (ø)
src/assemble_workflow/assemble_args.py 100.00% <ø> (ø)
src/assemble_workflow/bundle.py 95.12% <ø> (ø)
src/assemble_workflow/bundle_file_location.py 100.00% <ø> (ø)
src/assemble_workflow/bundle_location.py 92.30% <ø> (ø)
... and 150 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will leave to @bbarani and @dblock to merge this if they are okay.

@dblock dblock merged commit bd9d214 into opensearch-project:main Sep 28, 2022
@Divyaasm Divyaasm deleted the addheader branch October 20, 2022 16:25
monusingh-1 pushed a commit to monusingh-1/os_build that referenced this pull request Nov 2, 2022
* License Header Checker

Signed-off-by: Divya Madala <[email protected]>

* License Header checker.

Signed-off-by: Divya Madala <[email protected]>

* License Header checker.

Signed-off-by: Divya Madala <[email protected]>

* License Header checker

Signed-off-by: Divya Madala <[email protected]>

* License Header checker

Signed-off-by: Divya Madala <[email protected]>

* License Header checker

Signed-off-by: Divya Madala <[email protected]>

* License Header checker

Signed-off-by: Divya Madala <[email protected]>

* License Header checker

Signed-off-by: Divya Madala <[email protected]>

* License Header checker

Signed-off-by: Divya Madala <[email protected]>

* License Header checker

Signed-off-by: Divya Madala <[email protected]>

Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Monu Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants