-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a License header Checker #2666
Conversation
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala <[email protected]>
Hey @Divyaasm qq, will the License header Checker, check's the entire following lines?
or just |
It checks for the two lines |
Got it thanks @Divyaasm , but I believe the entire sentence should be part of license check?
From Core https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/src/main/java/org/opensearch/gradle/pluginzip/Publish.java#L1-L7 |
@prudhvigodithi We ran a campaign last year and used the 2 liner license text as mentioned here. @dblock Do you have any feedback on this license text? |
Signed-off-by: Divya Madala <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2666 +/- ##
=========================================
Coverage 93.94% 93.94%
Complexity 28 28
=========================================
Files 219 219
Lines 4494 4494
Branches 29 29
=========================================
Hits 4222 4222
Misses 266 266
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* License Header Checker Signed-off-by: Divya Madala <[email protected]> * License Header checker. Signed-off-by: Divya Madala <[email protected]> * License Header checker. Signed-off-by: Divya Madala <[email protected]> * License Header checker Signed-off-by: Divya Madala <[email protected]> * License Header checker Signed-off-by: Divya Madala <[email protected]> * License Header checker Signed-off-by: Divya Madala <[email protected]> * License Header checker Signed-off-by: Divya Madala <[email protected]> * License Header checker Signed-off-by: Divya Madala <[email protected]> * License Header checker Signed-off-by: Divya Madala <[email protected]> * License Header checker Signed-off-by: Divya Madala <[email protected]> Signed-off-by: Divya Madala <[email protected]> Signed-off-by: Monu Singh <[email protected]>
Description
-Created a workflow to to check for Header Licenses in files.
-Added license Header for files missing them.
-Updated files include - " python,groovy,js,ts,sh "
Issues Resolved
Workflow checks for the presence of Header License on push and pull requests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.