Make input manifest ci checks accept commit id as refs

[peterzhuamazon]

Signed-off-by: Peter Zhu [email protected]

Description

Make input manifest ci checks accept commit id as refs

Issues Resolved

#2855
#2649

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #2856 (764fc9b) into main (b4e98c7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2856      +/-   ##
==========================================
+ Coverage   93.66%   93.71%   +0.04%     
==========================================
  Files         158      158              
  Lines        4373     4391      +18     
==========================================
+ Hits         4096     4115      +19     
+ Misses        277      276       -1     

Impacted Files	Coverage Δ
src/ci_workflow/ci_check_list.py	94.73% <100.00%> (+2.42%)	⬆️
src/ci_workflow/ci_check_list_source_ref.py	100.00% <100.00%> (+6.66%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[zelinh]

LGTM. Had offline discussion with @peterzhuamazon. This would be performed when checks in input manifest are absent.

[dblock]

This should have been implemented differently by adding two subclasses of CiCheckListSourceRef, one that has a ref as SHA1 and another that doesn't, instead of all these ifs and creating the right instance thereof accordingly. Care to refactor this @zelinh?

[peterzhuamazon]

This should have been implemented differently by adding two subclasses of CiCheckListSourceRef, one that has a ref as SHA1 and another that doesn't, instead of all these ifs and creating the right instance thereof accordingly. Care to refactor this @zelinh?

This is a temp measure to unblock 2.4.0.
We will refactor it later on.

Thanks.

[dblock]

@peterzhuamazon Later on is fine by me. Please note that a cleaner object model would have been less code and much more readable. Whether the measure is temporary is irrelevant.