Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Label creation automation #3660

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

prudhvigodithi
Copy link
Collaborator

@prudhvigodithi prudhvigodithi commented Jun 22, 2023

Description

Release Label creation automation

Issues Resolved

#3661

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #3660 (f218812) into main (8fb3588) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3660   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         181      181           
  Lines        5381     5381           
=======================================
  Hits         4923     4923           
  Misses        458      458           

Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi
Copy link
Collaborator Author

prudhvigodithi commented Jun 22, 2023

The logic works as expected, however need to test after merging to main if the used github_app_token is able to create/add labels to external repos (I assume this to work as expected).
Screenshot 2023-06-22 at 3 05 12 PM
Screenshot 2023-06-22 at 3 04 44 PM

@prudhvigodithi prudhvigodithi marked this pull request as ready for review June 22, 2023 22:28
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Thanks @prudhvigodithi

Once we know this works, can you remove the step to create labels from release template?
Thanks!

@prudhvigodithi prudhvigodithi merged commit 936048c into opensearch-project:main Jun 22, 2023
11 checks passed
@prudhvigodithi prudhvigodithi added the enhancement New Enhancement label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants