Update opensearch-2.9.0-test.yml with sql dummy master key for testing. #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new datasources master key config required for datasource APIs. Signed-off-by: Vamsi Manohar <[email protected]>
vamsi-amazon
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3738 +/- ##
==========================================
- Coverage 91.54% 91.53% -0.02%
==========================================
Files 182 182
Lines 5420 5420
==========================================
- Hits 4962 4961 -1
- Misses 458 459 +1 |
There was a problem hiding this comment.
Hi @vamsi-amazon is it ok to show this masterkey? Or is this just a dummy?
Thanks.
|
@peterzhuamazon This is dummy one for integ test cluster domain. For customer domains, user has to set this up on their own. Since integ test domains are temporary ones, it won't be an issue. |
peterzhuamazon
approved these changes
Jul 14, 2023
peterzhuamazon
changed the title
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new datasources master key config required for datasource APIs.
Issues Resolved
Fix for Integ test failure opensearch-project/sql#1866 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.