Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish-snapshot.sh script to only push artifacts ending with -SNAPSHOT #447

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Sep 10, 2021

Fix publish-snapshot.sh script to only push artifacts ending with -SNAPSHOT.jar|war|zip.

Signed-off-by: Marc Handalian [email protected]

Description

This change ensures we are not pushing incorrect artifacts with the deploy:deploy-file plugin.
All publications will name the real artifact that needs to be published end with -SNAPSHOT..

Removed line explicitly checking for sources/javadoc jars. These will be skipped bc they do not end in -SNAPSHOT.<extension>

Tested this with a local run that skips the mvn publish command to ensure we attempt to push the correct files.

~/workspace/opensearch-build (main)$ ./publish/publish-snapshot.sh test
searching for poms under /Users/handalm/workspace/opensearch-build/test
Skipping upload for additional artifact: ./1.1.0-SNAPSHOT/build-tools-1.1.0-SNAPSHOT-javadoc.jar
Skipping upload for additional artifact: ./1.1.0-SNAPSHOT/build-tools-1.1.0-SNAPSHOT-sources.jar
Skipping upload for additional artifact: ./1.1.0-SNAPSHOT/build-tools-1.1.0-SNAPSHOT-test-fixtures.jar
Uploading: ./1.1.0-SNAPSHOT/build-tools-1.1.0-SNAPSHOT.jar with ./1.1.0-SNAPSHOT/build-tools-1.1.0-SNAPSHOT.pom to https://aws.oss.sonatype.org/content/repositories/snapshots/
Skipping upload for ./1.1.0-SNAPSHOT/build-tools-1.1.0-SNAPSHOT.module
Skipping upload for ./1.1.0-SNAPSHOT/maven-metadata-local.xml
Finished uploading ./1.1.0-SNAPSHOT
===========================================
Done.
===========================================

Issues Resolved

#439

Check List

  • [ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

publish/publish-snapshot.sh Outdated Show resolved Hide resolved
dblock
dblock previously approved these changes Sep 10, 2021
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@mch2 mch2 merged commit d7ab763 into opensearch-project:main Sep 13, 2021
@mch2 mch2 deleted the snapshot-fix branch September 13, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants