Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove subdirectory for gantt-chart in 1.3.15 #4492

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

joshuali925
Copy link
Member

Description

Gantt chart build is failing due to #4375. This was called out in the original PR

In all future release versions (>=3.0.0, >=2.12.0, >=1.3.15), the manifest file should not include working_directory: gantt-chart

as well as confirmed in this issue opensearch-project/dashboards-visualizations#327 (comment), but somehow still missed in the new 1.3.15 manifest

Issues Resolved

opensearch-project/dashboards-visualizations#349

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (2e2e85c) to head (b08fb92).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4492   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         192      192           
  Lines        6292     6292           
=======================================
  Hits         5801     5801           
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuali925 joshuali925 changed the title remove subdirectory for gantt-chart in 1.13.15 remove subdirectory for gantt-chart in 1.3.15 Mar 1, 2024
@jordarlu jordarlu merged commit 54fe778 into opensearch-project:main Mar 1, 2024
13 checks passed
@jordarlu
Copy link
Contributor

jordarlu commented Mar 1, 2024

part of [RELEASE] Release version 1.3.15

Divyaasm pushed a commit to Divyaasm/opensearch-build that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants