Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloudfront validation role for promotion workflow #4808

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jun 28, 2024

Description

Fix cloudfront validation role for promotion workflow.
I have updated the permissions as well as updated the cloudfront distribution ID.

Issues Resolved

#4801

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you change to the correct CLOUDFRONT_DISTRIBUTION_ID as well?
Since the jenkins one and public ones should have different ids.

Thanks.

@gaiksaya
Copy link
Member Author

Did you change to the correct CLOUDFRONT_DISTRIBUTION_ID as well? Since the jenkins one and public ones should have different ids.

Thanks.

yes!

@gaiksaya gaiksaya merged commit 5d5b77d into opensearch-project:main Jun 28, 2024
11 checks passed
@gaiksaya gaiksaya deleted the fix-promotion-workflow branch June 28, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants