Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up cmake version to 3.26.4 #4822

Merged

Conversation

naveentatikonda
Copy link
Member

@naveentatikonda naveentatikonda commented Jul 8, 2024

Description

Bump up cmake version to 3.26.4 to fix the failing CI in k-NN plugin

https://github.com/opensearch-project/k-NN/actions/runs/9822873197/job/27120072059?pr=1796

CMake Error at external/faiss/CMakeLists.txt:21 (cmake_minimum_required):
CMake 3.24.0 or higher is required.  You are running version 3.23.3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have an offline talk with @naveentatikonda and he will double check if there is a higher version of cmake we can move to to avoid constant update of images.

As of now faiss label to be at least 3.24.0

for

Let's see if we can bump to 3.24.3 as least as that is the last version available on scoop for windows.

Thanks.

@naveentatikonda naveentatikonda changed the title Bump up cmake version to 3.24.0 Bump up cmake version to 3.26.4 Jul 8, 2024
@naveentatikonda
Copy link
Member Author

Tested with CMake version 3.26.4 on Linux machine and able to build k-NN libraries, so bumping cmake version to 3.26.4

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @naveentatikonda can you remove all the changes for items within legacy folder as they should remain the same as old templates.

Thanks.

Signed-off-by: Naveen Tatikonda <[email protected]>
@naveentatikonda
Copy link
Member Author

naveentatikonda commented Jul 8, 2024

Hi @naveentatikonda can you remove all the changes for items within legacy folder as they should remain the same as old templates.

@peterzhuamazon reverted those changes in legacy folder. Pls take a look

@peterzhuamazon peterzhuamazon merged commit df3c353 into opensearch-project:main Jul 8, 2024
12 checks passed
@peterzhuamazon
Copy link
Member

Hi @naveentatikonda can you remove all the changes for items within legacy folder as they should remain the same as old templates.

@peterzhuamazon reverted those changes in legacy folder. Pls take a look

Thanks @naveentatikonda , I will trigger the image building now.
Will update.

@prudhvigodithi
Copy link
Collaborator

Using opensearchstaging/ci-runner:ci-runner-al2-opensearch-build-v1 and "sha256:e580791eeb37f0c1ebb55729f29bc143296d8f9a03de752f93fe017fcf79eea6", I get the error as CMake 3.24.0 or higher is required. You are running version 3.23.3. The actual cmake version inside the image is cmake version 3.23.3.

@prudhvigodithi
Copy link
Collaborator

Using opensearchstaging/ci-runner:ci-runner-al2-opensearch-build-v1 and "sha256:e580791eeb37f0c1ebb55729f29bc143296d8f9a03de752f93fe017fcf79eea6", I get the error as CMake 3.24.0 or higher is required. You are running version 3.23.3. The actual cmake version inside the image is cmake version 3.23.3.

Please ignore the latest sha of opensearchstaging/ci-runner:ci-runner-al2-opensearch-build-v1 has cmake version 3.26.4.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants