-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validation workflow params in central release workflow #4860
Conversation
LGTM! issue is only with the parameter AFAIK. https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/validate-artifacts/validate-artifacts.jenkinsfile#L93C9-L111C48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix here!
Signed-off-by: Sayali Gaikawad <[email protected]>
@@ -497,7 +497,7 @@ pipeline { | |||
string(name: 'PROJECTS', value: 'Both'), | |||
string(name: 'DOCKER_SOURCE', value: 'Both'), | |||
string(name: 'ARTIFACT_TYPE', value: 'production'), | |||
string(name: 'OPTIONAL_ARGS', value: 'validate-digests-only') | |||
string(name: 'OPTIONAL_ARGS', value: 'validate-digest-only') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
==========================================
- Coverage 92.31% 92.07% -0.25%
==========================================
Files 193 193
Lines 6445 6445
==========================================
- Hits 5950 5934 -16
- Misses 495 511 +16 ☔ View full report in Codecov by Sentry. |
Description
The most recent central promotion workflow failed due to parameter type variation. See https://build.ci.opensearch.org/blue/organizations/jenkins/central-release-promotion/detail/central-release-promotion/10/pipeline
This change fixes the parameter value.
Issues Resolved
#4801
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.