Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic of finding legacy branches to ignore manifest update #4871

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jul 19, 2024

Description

Improve logic of finding legacy branches to ignore manifest update
Using legacy-manifests folder as indicator of legacy branch and cross checking with current manifests.

Issues Resolved

Follow up to: #4867
Closes #4870

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon self-assigned this Jul 19, 2024
@peterzhuamazon peterzhuamazon changed the title Improve logic of finding legacy branchs to ignore manifest update Improve logic of finding legacy branches to ignore manifest update Jul 19, 2024
@peterzhuamazon
Copy link
Member Author

Results:

2024-07-19 18:44:24 INFO     Known versions: ['1.0.0', '1.0.1', '1.1.0', '1.1.1', '1.2.0', '1.2.1', '1.2.2', '1.2.3', '1.2.4', '1.2.5', '1.3.0', '1.3.1', '1.3.2', '1.3.3', '1.3.4', '1.3.5', '1.3.6', '1.3.7', '1.3.8', '1.3.9', '1.3.10', '1.3.11', '1.3.12', '1.3.13', '1.3.14', '1.3.15', '1.3.16', '1.3.17', '1.3.18', '1.4.0', '2.0.0', '2.0.1', '2.0.2', '2.1.0', '2.1.1', '2.2.0', '2.2.1', '2.2.2', '2.3.0', '2.3.1', '2.4.0', '2.4.1', '2.4.2', '2.5.0', '2.5.1', '2.6.0', '2.6.1', '2.7.0', '2.7.1', '2.8.0', '2.8.1', '2.9.0', '2.9.1', '2.10.0', '2.10.1', '2.11.0', '2.11.1', '2.11.2', '2.12.0', '2.12.1', '2.13.0', '2.13.1', '2.14.0', '2.14.1', '2.15.0', '2.15.1', '2.16.0', '3.0.0']
2024-07-19 18:44:24 INFO     Checking out components into /var/folders/3m/3z1h4cv934z_dxprx6ygmm6w0000gq/T/tmp14gz0ia_
2024-07-19 18:44:25 INFO     Checking OpenSearch ['1.3', '1.x', '2.12', '2.13', '2.14', '2.15', '2.x', 'main'] branches
2024-07-19 18:44:25 INFO     Ignoring OpenSearch ['1.0', '1.1', '1.2', '2.0', '2.1', '2.10', '2.11', '2.2', '2.3', '2.4', '2.5', '2.5-transfer', '2.6', '2.7', '2.8', '2.9'] branches as they are outdated
2024-07-19 18:44:25 INFO     Executing "git init" in /var/folders/3m/3z1h4cv934z_dxprx6ygmm6w0000gq/T/tmp14gz0ia_/OpenSearch/1.3
2024-07-19 18:44:25 INFO     Executing "git remote add origin https://github.com/opensearch-project/OpenSearch.git" in /var/folders/3m/3z1h4cv934z_dxprx6ygmm6w0000gq/T/tmp14gz0ia_/OpenSearch/1.3
2024-07-19 18:44:25 INFO     Executing "git fetch --depth 1 origin 1.3" in /var/folders/3m/3z1h4cv934z_dxprx6ygmm6w0000gq/T/tmp14gz0ia_/OpenSearch/1.3

@peterzhuamazon peterzhuamazon merged commit cbbf84a into opensearch-project:main Jul 19, 2024
11 checks passed
@peterzhuamazon peterzhuamazon deleted the remove_outdated_manifest_branches branch July 19, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Enhancement] Ignore legacy branchs to when running manifest update
2 participants