Add platform compatibility check for incremental build #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
zelinh
requested review from
dblock,
peterzhuamazon,
gaiksaya,
rishabh6788,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4949 +/- ##
==========================================
- Coverage 92.17% 92.12% -0.06%
==========================================
Files 197 197
Lines 6634 6639 +5
==========================================
+ Hits 6115 6116 +1
- Misses 519 523 +4 ☔ View full report in Codecov by Sentry. |
gaiksaya
reviewed
Aug 16, 2024
| @@ -31,6 +33,9 @@ def commits_diff(self, input_manifest: InputManifest) -> List[str]: | |||
| return [input_manifest.build.name.replace(" ", "-")] | |||
| components = [] | |||
| for component in stable_input_manifest.components.select(): | |||
| if component.platforms and self.platform not in component.platforms: | |||
| logging.info(f"Skipping {component.name} as it's not compatible on {self.platform}.") | |||
There was a problem hiding this comment.
Suggested change
| logging.info(f"Skipping {component.name} as it's not compatible on {self.platform}.") | |
| logging.info(f"Skipping {component.name} as it is not compatible with {self.platform}.") |
Signed-off-by: Zelin Hao <[email protected]>
gaiksaya
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add platform compatibility check for incremental build.
Issues Resolved
#4545
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.