-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the clients release docker image to AlmaLinux 8 #4985
Update the clients release docker image to AlmaLinux 8 #4985
Conversation
Allows upgrading to .NET SDK 8.0 Signed-off-by: Thomas Farr <[email protected]>
e9d55ae
to
f95c591
Compare
Taking a look. |
How about keep both files under current? As other clients are using the current ones. You can override the default one by new image using https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/standardReleasePipelineWithGenericTrigger.groovy#L15 |
I am ok to actually start migrating to alma8 for other clients now. The CentOS7 image is on dockerhub already so we can move the dockerfile to legacy to prevent new builds and can start the migrations as needed. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Xtansia thanks for the PR here.
The file has been altered a bit compares to the original dockerfile.
Could you please take a look on it? Thanks.
docker/ci/dockerfiles/current/release.almalinux8.clients.x64.arm64.dockerfile
Outdated
Show resolved
Hide resolved
docker/ci/dockerfiles/current/release.almalinux8.clients.x64.arm64.dockerfile
Outdated
Show resolved
Hide resolved
docker/ci/dockerfiles/current/release.almalinux8.clients.x64.arm64.dockerfile
Outdated
Show resolved
Hide resolved
docker/ci/dockerfiles/current/release.almalinux8.clients.x64.arm64.dockerfile
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Farr <[email protected]>
Thanks @Xtansia ! |
Will build image. |
Description
Update the clients release docker image to AlmaLinux 8.
Allows upgrading to .NET SDK 8.0. opensearch-net now uses .NET SDK 8.0 to build, but current image only has 6.0, leading to a release failure. CentOS 7 is not supported by Microsoft anymore and so .NET 8.0 is unavailable without upgrading.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.