Fixed deserialization of SearchRequest when _source is an array
#1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
force-pushed
the
fix/search_source_as_array
branch
from
714de50
to
c21df84
Compare
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
dblock
approved these changes
Aug 1, 2024
|
Looks like backport didn't run when label applied before merging the PR. Might need an update to trigger only on merged PRs after a merge or label added like now. |
dblock
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
) * Add failing test Signed-off-by: Thomas Farr <[email protected]> * Fixed deserialization of SearchRequest when `_source` is an array Signed-off-by: Thomas Farr <[email protected]> * Fix docker compose error Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 45b805a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
pushed a commit
that referenced
this pull request
Aug 1, 2024
) (#1118) * Add failing test * Fixed deserialization of SearchRequest when `_source` is an array * Fix docker compose error --------- (cherry picked from commit 45b805a) Signed-off-by: Thomas Farr <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dancristiancecoi
pushed a commit
to dancristiancecoi/opensearch-java
that referenced
this pull request
Aug 8, 2024
…ensearch-project#1117) * Add failing test Signed-off-by: Thomas Farr <[email protected]> * Fixed deserialization of SearchRequest when `_source` is an array Signed-off-by: Thomas Farr <[email protected]> * Fix docker compose error Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed deserialization of SearchRequest when
_sourceis an arrayIssues Resolved
Fixes #1087
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.