Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix queries losing inherited data when toBuilder is called. (#1181) #1184

Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Sep 4, 2024

Description

Backport #1181 via 020e0b0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ch-project#1181)

* Fixes opensearch-project#1172

Calling `toBuilder` on classes which implement `QueryBase` will now preserve `boost` and `queryName`.

Signed-off-by: Chris Danisch <[email protected]>

* Updated changelog

Signed-off-by: Chris Danisch <[email protected]>

* Added toBuilder to QueryBase instead.

Signed-off-by: Chris Danisch <[email protected]>

---------

Signed-off-by: Chris Danisch <[email protected]>
(cherry picked from commit 020e0b0)
Signed-off-by: Thomas Farr <[email protected]>
@Xtansia Xtansia force-pushed the backport/backport-1181-to-2.x branch from c93672c to 0dceb59 Compare September 4, 2024 21:59
@dblock dblock merged commit aff091f into opensearch-project:2.x Sep 5, 2024
48 of 49 checks passed
@Xtansia Xtansia deleted the backport/backport-1181-to-2.x branch September 5, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants