Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix: do not double-wrap OpenSearchException. #332

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 37d4800 from #323

dblock
dblock previously approved these changes Jan 17, 2023
VachaShah
VachaShah previously approved these changes Jan 17, 2023
@dblock
Copy link
Member

dblock commented Jan 17, 2023

@VachaShah Do you know how to fix the backports DCO here? Will upgrading to https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/backport.yml just work?

Signed-off-by: dblock <[email protected]>

(cherry picked from commit 37d4800)
@dblock dblock dismissed stale reviews from VachaShah and themself via a5a248d January 17, 2023 20:20
@dblock dblock force-pushed the backport/backport-323-to-2.x branch from ad1398d to a5a248d Compare January 17, 2023 20:20
@dblock dblock requested a review from VachaShah January 18, 2023 18:05
dblock
dblock previously approved these changes Jan 18, 2023
@VachaShah
Copy link
Collaborator

@VachaShah Do you know how to fix the backports DCO here? Will upgrading to https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/backport.yml just work?

The DCO problem might need looking into. The new version of backport action just offers some new features.

VachaShah
VachaShah previously approved these changes Jan 19, 2023
@dblock dblock dismissed stale reviews from VachaShah and themself via e049b35 January 19, 2023 23:51
@VachaShah VachaShah requested a review from dblock January 23, 2023 06:06
@reta reta merged commit 7eae121 into 2.x Jan 23, 2023
@github-actions github-actions bot deleted the backport/backport-323-to-2.x branch January 23, 2023 14:00
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants