Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add option to set headers and sort options in cat requests #413

Merged
merged 1 commit into from
Mar 21, 2023
Merged

[Backport 2.x] Add option to set headers and sort options in cat requests #413

merged 1 commit into from
Mar 21, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 938170a from #412.

@dblock
Copy link
Member

dblock commented Mar 21, 2023

Looks like the backport will need some manual work @MarinaRazumovsky , tests failed.

MarinaRazumovsky
MarinaRazumovsky reviewed Mar 21, 2023
View reviewed changes
java-client/src/test/java/org/opensearch/client/opensearch/integTest/restclient/CatIT.java Outdated

package org.opensearch.client.opensearch.integTest.restclient;

import org.apache.hc.core5.http.HttpHost;
Copy link
Contributor

@MarinaRazumovsky MarinaRazumovsky Mar 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dblock , it should be this import, but I have not permissions to change code
import org.apache.http.HttpHost;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarinaRazumovsky I will take care of it, thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both! Next time feel free to open another PR, might be faster than waiting for a maintainer to amend/fix/force push.

@github-actions @VachaShah
@iamdanhart @andrross @reta @AmiStrn @szczepanczykd @dblock @dependabot @gaiksaya @L00kian @luneo7
Add option to set headers and sort options in cat requests (#412)
ec17c60 
* Adding x-amz-content-sha256 header for signed requests (#339)

* Adding X-Amz-Content-Sha256 header for signed requests

Signed-off-by: Vacha Shah <[email protected]>

* Adding CHANGELOG entry

Signed-off-by: Vacha Shah <[email protected]>

* Adding documentation comment

Signed-off-by: Vacha Shah <[email protected]>

* Adding tests

Signed-off-by: Vacha Shah <[email protected]>

* Addressing comments

Signed-off-by: Vacha Shah <[email protected]>

* Addressing comments

Signed-off-by: Vacha Shah <[email protected]>

* Removing refresh policy for integ tests for Sigv4

Signed-off-by: Vacha Shah <[email protected]>

* Updating the developer guide

Signed-off-by: Vacha Shah <[email protected]>

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fix issue with completion suggester being parsed as term suggester. (#347)

* Fix issue with completion suggester being parsed as term suggester.

This commit fixes the issue where a completion suggester search request
was being parsed as a term suggester and failing due to "Missing
required property 'TermSuggestOption.score'"

This solution was originally proposed by Github user @apatrida

Signed-off-by: Dan Hart <[email protected]>

* Remove commented code

Signed-off-by: Dan Hart <[email protected]>

* Fix format of changelog item

Signed-off-by: Dan Hart <[email protected]>

Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Update USER_GUIDE to use exact AWS brand names (#352)

Minor update to use exact brand names. "OpenSearch" is rather overloaded
to I find it less confusing to be precise in the naming.

Signed-off-by: Andrew Ross <[email protected]>

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bumps Jackson from 2.14.1 to 2.14.2 (#357)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bulk UpdateOperation misses upsert options (#353)

* Bulk UpdateOperation misses upsert options

Signed-off-by: Andriy Redko <[email protected]>

* Fix formatting

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Upgrading compatibility to opensearch 2.5 (#367)

* Upgrading compatibility to opensearch 2.5

Signed-off-by: amitai stern <[email protected]>

* latest 2.4 version

Signed-off-by: amitai stern <[email protected]>

* keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0

Signed-off-by: amitai stern <[email protected]>

---------

Signed-off-by: amitai stern <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* add option to set columns into cat indices request

Signed-off-by: MarinaRazumovsky <[email protected]>

* add changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests

Signed-off-by: MarinaRazumovsky <[email protected]>

* Feature/range aggregation fix 369 (#370)

* test: create integration tests for date_range and range aggregation (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

* fix: add a missing key propery to the RangeBucket (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

* docs: add CHANGELOG entry (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

---------

Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fixing integration tests (#375)

* Fixing integration tests

Signed-off-by: Vacha Shah <[email protected]>

* Updating the test with a non-exact check

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Adding bulk request example in user guide (#373)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fixing issue when tracktotalhits is disabled (#372)

* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <[email protected]>

* Update Changelog

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* changes changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add 2PR approval to release workflow (#383)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Adding an example to use raw JSON class instead of target classes (#385)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Update Gradle to 8.0.2 (#392)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add "mappings" field to IndexSettings object (#382)

Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Created untriaged issue workflow. (#364)

Signed-off-by: dblock <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (#403)

* Bump io.github.classgraph:classgraph in /java-client

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add buffered lookahead for Jackson (#338)

Signed-off-by: luneo7 <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Mask env values for snapshots (#411)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* option to set headers and sort into cat requests

Signed-off-by: MarinaRazumovsky <[email protected]>

* fix test

Signed-off-by: MarinaRazumovsky <[email protected]>

* fix changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* add cat examples into USER_GUID

Signed-off-by: MarinaRazumovsky <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>
Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: amitai stern <[email protected]>
Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: luneo7 <[email protected]>
Co-authored-by: Vacha Shah <[email protected]>
Co-authored-by: Danny Hart <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Co-authored-by: amitai stern <[email protected]>
Co-authored-by: szczepanczykd <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Ilya Lukyanovich <[email protected]>
Co-authored-by: Lucas Rogerio Caetano Ferreira <[email protected]>
(cherry picked from commit 938170a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the backport/backport-412-to-2.x branch from 1b186cc to ec17c60 Compare March 21, 2023 17:15
@reta
Copy link
Collaborator

reta commented Mar 21, 2023

@dblock @MarinaRazumovsky all good now :)

@dblock dblock merged commit 402c6b9 into 2.x Mar 21, 2023
@github-actions github-actions bot deleted the backport/backport-412-to-2.x branch March 21, 2023 19:21
@AmiStrn
Copy link
Contributor

AmiStrn commented Mar 26, 2023

@dblock when can we expect the next release of this client with the above changes? is there a cadence/schedule of some sort? (before we go ahead and work off a forked version...)

@VachaShah
Copy link
Collaborator

Hi @AmiStrn, currently we don't have a release cadence, but feel free to open an issue for the next release similar to #380, we can take it from there.

@AmiStrn AmiStrn mentioned this pull request Apr 4, 2023
Closed
@AmiStrn
Copy link
Contributor

AmiStrn commented Apr 4, 2023

@VachaShah - I opened #426

Not sure regarding the other two commits since @MarinaRazumovsky's fix if they should be included or not.

@ls-urs-keller ls-urs-keller mentioned this pull request Jan 19, 2024
Closed
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@MarinaRazumovsky MarinaRazumovsky MarinaRazumovsky left review comments

@dblock dblock dblock approved these changes

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@madhusudhankonda madhusudhankonda Awaiting requested review from madhusudhankonda madhusudhankonda is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dblock @reta @AmiStrn @VachaShah @MarinaRazumovsky