Fixing issues when deserializing response for tasks API #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VachaShah
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda and
saratvemulapalli
as code owners
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
reta
reviewed
Apr 26, 2023
java-client/src/main/java/org/opensearch/client/opensearch/_types/BaseNode.java
Show resolved
Hide resolved
reta
reviewed
Apr 26, 2023
| @@ -23,6 +23,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ## [Unreleased 2.x] | |||
|
|
|||
| ### Added | |||
| - Add workflow to publish snapshots via GHA ([#454](https://github.com/opensearch-project/opensearch-java/pull/454)) | |||
There was a problem hiding this comment.
This was added to make it consistent with the Changelog on 2.x branch.
reta
previously approved these changes
Apr 26, 2023
Signed-off-by: Vacha Shah <[email protected]>
reta
approved these changes
May 1, 2023
dblock
approved these changes
May 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 3, 2023
* Fix failure when deserializing response for tasks API Signed-off-by: Vacha Shah <[email protected]> * Add changelog Signed-off-by: Vacha Shah <[email protected]> * Marking the fields Nullable Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]> (cherry picked from commit 4b9bcbc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VachaShah
pushed a commit
that referenced
this pull request
May 3, 2023
* Fix failure when deserializing response for tasks API * Add changelog * Marking the fields Nullable --------- (cherry picked from commit 4b9bcbc) Signed-off-by: Vacha Shah <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting the task attributes to not required since Amazon OpenSearch Service does not return them as stated in #356.
Issues Resolved
Closes #356
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.