Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PutIndexTemplateRequest deserialization #765

Conversation

matthewbogner
Copy link
Contributor

@matthewbogner matthewbogner commented Dec 12, 2023

Description

This PR adds in the missing deserialization steps to the PutIndexTemplateRequest _DESERIALIZER which would result in the error
Missing required property 'PutIndexTemplateRequest.name' if you tried to deserialize a request object.

Issues Resolved

Relates to issues #417, #618 and PR #723

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@matthewbogner matthewbogner force-pushed the mbogner-putindextemplaterequest-deser branch from f78b520 to 5a36989 Compare December 12, 2023 04:34
Signed-off-by: Matthew Bogner <[email protected]>
Signed-off-by: Matthew Bogner <[email protected]>
@VachaShah VachaShah merged commit d4aade4 into opensearch-project:main Dec 12, 2023
45 checks passed
@VachaShah VachaShah added the backport 2.x Backport to 2.x branch label Dec 12, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-765-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d4aade4e866556f8a11ed05756ab8b01f2ed0e71
# Push it to GitHub
git push --set-upstream origin backport/backport-765-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-765-to-2.x.

@dblock
Copy link
Member

dblock commented Dec 12, 2023

@matthewbogner Looks like this will need a manual backport if you want the fix in a 2.x release.

matthewbogner added a commit to matthewbogner/opensearch-java that referenced this pull request Dec 12, 2023
* Fix PutIndexTemplateRequest deserialization

Signed-off-by: Matthew Bogner <[email protected]>

* CHANGELOG.md

Signed-off-by: Matthew Bogner <[email protected]>

* spotless

Signed-off-by: Matthew Bogner <[email protected]>

---------

Signed-off-by: Matthew Bogner <[email protected]>
(cherry picked from commit d4aade4)
@matthewbogner matthewbogner deleted the mbogner-putindextemplaterequest-deser branch December 12, 2023 21:33
VachaShah pushed a commit that referenced this pull request Dec 12, 2023
* Fix PutIndexTemplateRequest deserialization

Signed-off-by: Matthew Bogner <[email protected]>

* CHANGELOG.md

Signed-off-by: Matthew Bogner <[email protected]>

* spotless

Signed-off-by: Matthew Bogner <[email protected]>

---------

Signed-off-by: Matthew Bogner <[email protected]>
(cherry picked from commit d4aade4)
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants