[Backport 2.x] Fix PutTemplateRequest deserialization (#723) #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VachaShah
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda and
saratvemulapalli
as code owners
reta
approved these changes
Feb 7, 2024
|
@VachaShah we may need to drop |
dblock
approved these changes
Feb 8, 2024
|
@VachaShah needs a DCO update |
* fix PutTemplateRequest deserialization Signed-off-by: bfindlay <[email protected]> * update changelog Signed-off-by: bfindlay <[email protected]> * fix changelog PR number Signed-off-by: bfindlay <[email protected]> * update for pr review Signed-off-by: bfindlay <[email protected]> * update unit test for pr Signed-off-by: bfindlay <[email protected]> * apply spotless check Signed-off-by: bfindlay <[email protected]> --------- Signed-off-by: bfindlay <[email protected]> Signed-off-by: Vacha Shah <[email protected]>
Done! |
For sure! we could do a |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix PutTemplateRequest deserialization
update changelog
fix changelog PR number
update for pr review
update unit test for pr
apply spotless check
Description
Backport of #723 to 2.x
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.