Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fixing cluster stats response for role types and adding search role type #849

Merged
merged 2 commits into from
Feb 15, 2024
Merged

[Backport 2.x] Fixing cluster stats response for role types and adding search role type #849

merged 2 commits into from
Feb 15, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 638d9b9 from #848.

@github-actions
Fixing cluster stats response for role types and adding search role t…
3571407 
…ype (#848)

* Fixing cluster stats response for role types and adding search role type

Signed-off-by: Vacha Shah <[email protected]>

* Add CHANGELOG

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
(cherry picked from commit 638d9b9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@VachaShah
Copy link
Collaborator

The new test in this PR is failing against 1.x OpenSearch with the following error:

> Task :java-client:integrationTest

org.opensearch.client.opensearch.integTest.httpclient5.ClusterClientIT > testClusterStats FAILED
    org.opensearch.client.util.MissingRequiredPropertyException at [82A5FF02283E99EE:B9E4E8BC8E491F98]:0

org.opensearch.client.opensearch.integTest.restclient.ClusterClientIT > testClusterStats FAILED
    org.opensearch.client.util.MissingRequiredPropertyException at [60FAF11EEC44C[50](https://github.com/opensearch-project/opensearch-java/actions/runs/7919902949/job/21623100079?pr=849#step:5:51)6:5BBBE6A04A334370]:0

This test does not fail on main and is not failing on my local machine. Looking into what is causing this failure.

@VachaShah
Copy link
Collaborator

Fixed the tests! @dblock Can I get a review for this backport?

@VachaShah VachaShah merged commit c32c230 into 2.x Feb 15, 2024
74 checks passed
@github-actions github-actions bot deleted the backport/backport-848-to-2.x branch February 15, 2024 21:20
@VachaShah VachaShah mentioned this pull request Feb 15, 2024
Merged
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VachaShah VachaShah VachaShah approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@madhusudhankonda madhusudhankonda Awaiting requested review from madhusudhankonda madhusudhankonda is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VachaShah