CI: run gradle commands in separate steps #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rursprung
requested review from
AmiStrn,
dblock,
saratvemulapalli and
reta
as code owners
reta
reviewed
Jun 11, 2024
rursprung
force-pushed
the
fix-ci
branch
2 times, most recently
from
5f0b84c
to
c6f6490
Compare
dblock
approved these changes
Jun 11, 2024
|
Looks like this caught (un)expected failures. |
reta
approved these changes
Jun 11, 2024
right now `./gradlew build` could fail but the script would still go on (because neither `set -e` is set nor `&&` is used to run both commands together). running it in two steps gives more visibilty to which step is failing. note that `publishPluginZipPublicationToZipStagingRepository` is tested explicitly to ensure that this step works as it has previously failed. fixes opensearch-project#60 Signed-off-by: Ralph Ursprung <[email protected]>
rursprung
changed the title
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-76-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 56f16a657551d0051014655466aa436cd4bf6c49
# Push it to GitHub
git push --set-upstream origin backport/backport-76-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
already backported in #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
right now
./gradlew buildcould fail but the script would still go on (because neitherset -eis set nor&&is used to run both commands together).the easiest solution is to just run both gradle target in one go as one anyway depends on the other - there's no need to start gradle twice. this will also make the runs ever so slightly faster.
Issues Resolved
fixes #60
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.