Documenting usage of overriding Default Distribution Download URL with custom URL by setting external property customDistributionUrl #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h custom URL by setting external property customDistributionUrl Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Rishikesh1159 <[email protected]>
saratvemulapalli
previously approved these changes
Feb 24, 2022
|
We rolled this back, right? Let us know when this can be merged @Rishikesh1159. |
|
Yes we rolled this back. Sure @dblock I will let you know once I open a PR and get it merged in OpenSearch repo, then we can merge this. |
|
@Rishikesh1159 we merged the changes to 2.0. |
Signed-off-by: Rishikesh1159 <[email protected]>
@saratvemulapalli small change was needed from last commit. Made it now, it is ready for review. |
|
@Rishikesh1159 should I merge this? I remember something about this change being reverted ... |
|
Yes @dblock please merge it. After reverting it was fixed and merged changes with this PR :opensearch-project/OpenSearch#2420 |
saratvemulapalli
approved these changes
Apr 21, 2022
dblock
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rishikesh1159 [email protected]
Description
This PR will allow developers to override Default Distribution Download URL with custom URL by setting "customDistributionUrl". This will help to pull artifacts from custom location for testing during release process.
Issues Resolved
#126
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.