-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding release artifacts for v0.1 of OpenSearch Migrations - Capture … #2015
base: main
Are you sure you want to change the base?
Adding release artifacts for v0.1 of OpenSearch Migrations - Capture … #2015
Conversation
…and Replay Signed-off-by: Brian Presley <[email protected]>
Signed-off-by: Brian Presley <[email protected]>
@sumobrian @AMoo-Miki - I'm getting an odd error when I pull them down locally to test: ContentIndexer: disabled. Enable with JEKYLL_ALLOW_CONTENT_INDEXER on the environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to Kris, i just noticed that you don't have individual artifacts for different platforms and architectures. As such:
- You shouldn't create multiple artifact deffinition files. please replace all of the
_artifacts/opensearch-migrations/opensearch-migrations-0.1.0-*-*.markdown
files with just one. - In that file, use
platform: all-platforms architecture: all-architectures
- Update the
platforms
in_layouts/versions.html
withall-platforms: "All Platforms"
- Update the
architectures
in_layouts/versions.html
withall-architectures: "All Architectures"
Signed-off-by: Brian Presley <[email protected]>
…for all architectures Signed-off-by: Brian Presley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Brian for the changes; this looks great technically. We should get Charlotte to also take a look at it.
Additionally, since this PR was raised, we have had 1.3.13 and 2.10.0 releases. The changes to the _versions
files should be in those versions; the PR currently modifies 1.3.12 and 2.9.0 files.
…and Replay
Description
This PR is to make OpenSearch Migration tooling artifacts available on the website. The website documentation has been updated and deploy and the artifacts referenced are available.
Issue
#2003
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.