Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] VisualReportHelper unit test is failing #99

Closed
zhongnansu opened this issue Jun 24, 2021 · 0 comments
Closed

[BUG] VisualReportHelper unit test is failing #99

zhongnansu opened this issue Jun 24, 2021 · 0 comments
Assignees
Labels
bug Something isn't working v1.0.0

Comments

@zhongnansu
Copy link
Member

zhongnansu commented Jun 24, 2021

Describe the bug
visualReportsHelper unit test is failing because we are using elastic demo url in unit test for reporting module to access and gernerate report.

Recently they change the html identifier from "#dashboardsViewport" to ".dashboardViewport".

Solution:
We should remove this dependency on elastic. Using a html locally and let pupeeter renders it is a better option

reference: https://stackoverflow.com/questions/65417870/how-to-mock-remote-website-responses-to-unit-test-puppeteer-code-with-jest

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@zhongnansu zhongnansu added bug Something isn't working Beta untriaged labels Jun 24, 2021
@zhongnansu zhongnansu self-assigned this Jun 24, 2021
kavilla pushed a commit to kavilla/dashboards-reports that referenced this issue Jul 12, 2023
)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 047eb96f528e05ad3dc792174c6b04cd1794dd41)

Co-authored-by: Joshua Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.0.0
Projects
None yet
Development

No branches or pull requests

1 participant