[1.2] Fix reporting validation for observability (#231)

[joshuali925]

Signed-off-by: Joshua Li [email protected]

Description

Backport #231

Issues Resolved

#232

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[davidcui1225]

LGTM- did we get approval to introduce this into 1.2?

[joshuali925]

LGTM- did we get approval to introduce this into 1.2?

No, just opened it in case, but don't merge it yet

[codecov-commenter]

Codecov Report

Merging #233 (5adc2fc) into 1.2 (4dd52ac) will decrease coverage by 9.97%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.2     #233      +/-   ##
============================================
- Coverage     64.54%   54.57%   -9.98%     
  Complexity      294      294              
============================================
  Files            97       64      -33     
  Lines          4045     2056    -1989     
  Branches        620      234     -386     
============================================
- Hits           2611     1122    -1489     
+ Misses         1293      796     -497     
+ Partials        141      138       -3     

Flag	Coverage Δ
dashboards-reports	?
reports-scheduler	54.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ashboards-reports/server/utils/validationHelper.ts
...rt_definitions/report_settings/report_settings.tsx
dashboards-reports/public/components/main/main.tsx
...eports/public/components/utils/settings_service.ts
...orts/server/routes/utils/converters/backendToUi.ts
...s-reports/server/routes/utils/dataReportHelpers.ts
...ions/report_settings/report_settings_constants.tsx
dashboards-reports/server/model/index.ts
...ashboards-reports/server/routes/utils/constants.ts
...main/__tests__/__utils__/main_utils_test_utils.tsx
... and 23 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd52ac...5adc2fc. Read the comment docs.