Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORTANT NOTIFICATION] Transition from Angular to React in OpenSearch Dashboards - Action Required #1504

Closed
ananzh opened this issue Jul 6, 2023 · 7 comments
Assignees
Labels
triaged v2.9.0 Label description

Comments

@ananzh
Copy link
Member

ananzh commented Jul 6, 2023

Description

As part of our ongoing efforts to improve the OpenSearch Dashboards' performance, maintainability, and developer experience, we have decided to de-angularize the dashboard.

This change will impact all plugins that use the OpenSearch Dashboard dashboard and require your attention to ensure the compatibility and performance of your plugins. If your plugin has nothing to do with dashboard, please close the issue.

We suggest a thoroughly test of your plugin on new dashboard. Here are some steps:

We understand that this transition may require significant work on your part, and we are here to support you during this process. If there is any concerns or issues, feel free to comment here. If there is a bug, please also add it to opensearch-project/OpenSearch-Dashboards#4505.

@stephen-crawford
Copy link
Contributor

[Triage] @RyanL1997 and @cwperks are going to take a look and confirm status.

@stephen-crawford stephen-crawford added v2.9.0 Label description and removed untriaged labels Jul 7, 2023
@RyanL1997
Copy link
Collaborator

RyanL1997 commented Jul 10, 2023

Testing Result on my testing branch:

  1. Cypress Tests: https://github.com/RyanL1997/security-dashboards-plugin/actions/runs/5489253864 (Pass ✅)
  2. Cypress Tests of Multi-tenancy: https://github.com/RyanL1997/security-dashboards-plugin/actions/runs/5489253858 (Pass ✅)
  3. Unit Tests : https://github.com/RyanL1997/security-dashboards-plugin/actions/runs/5489253857 (Pass ✅)
  4. Integration Tests: https://github.com/RyanL1997/security-dashboards-plugin/actions/runs/5489253859 (Pass on windows, for the multiple failures on linux for SAML integration test cases [1] ❌ Updated here)
  5. Manual Sanity Testing (Pass ✅)
  6. Functional Test based on main branch of FTR (Pass ✅)

Reference:

[1]: This is the same error on main branch: https://github.com/RyanL1997/security-dashboards-plugin/actions/runs/5512024002/jobs/10049175332

@RyanL1997
Copy link
Collaborator

RyanL1997 commented Jul 10, 2023

@opensearch-project/security
referencing to my above comment and double checking with you guys that if we can safely close this.

@RyanL1997
Copy link
Collaborator

Note: the above issue is happening on main also without Deangular Dashboard changes

@RyanL1997
Copy link
Collaborator

Update: the SAML issue has been addressed by opensearch-project/security#2987, and it is not related to the Deangular changes. I just initiated the re-run of the above failing test case.

@RyanL1997
Copy link
Collaborator

@RyanL1997
Copy link
Collaborator

Safely closing this one. (cc: @opensearch-project/security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged v2.9.0 Label description
Projects
None yet
Development

No branches or pull requests

3 participants