Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Switch to built-in security transports from core #4118

Closed
4 tasks
reta opened this issue Mar 15, 2024 · 1 comment · Fixed by #4119
Closed
4 tasks

[FEATURE] Switch to built-in security transports from core #4118

reta opened this issue Mar 15, 2024 · 1 comment · Fixed by #4119
Assignees
@reta
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v2.14.0 Issues and PRs related to version 2.14.0 v3.0.0

Comments

@reta
Copy link
Collaborator

reta commented Mar 15, 2024 •
edited
Loading

Is your feature request related to a problem?

As part of [1], the responsibility to provide the secure transports moves to NetworkPlugin, whereas the Plugin has been extended to provide SecureSettingsFactory.

[1] opensearch-project/OpenSearch#12256

What solution would you like?
The security plugin does not need to provide the secure transports anymore but SecureSettingsFactory so the core transport modules will be able to configure those.

  • Add SecureSettingsFactory
  • Remove SecuritySSLNettyHttpServerTransport & SecuritySSLNettyTransport
  • Preserve old SSL related settings
  • Update references in core with permalinks to 2.13.0 branch

What alternatives have you considered?
Keep everything in security plugin

Do you have any additional context?
See please opensearch-project/OpenSearch#12256
@reta reta added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Mar 15, 2024
@reta reta self-assigned this Mar 15, 2024
@reta reta added v2.14.0 Issues and PRs related to version 2.14.0 v3.0.0 labels Mar 15, 2024
This was referenced Mar 15, 2024
Merged
Merged
@cwperks cwperks added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Mar 18, 2024
@cwperks
Copy link
Member

cwperks commented Mar 18, 2024

[Triage] Thank you for filing the issue and opening a companion PR in the security plugin to show how the new secure transport modules in core can be configured from the security plugin.

reta added a commit that referenced this issue Mar 26, 2024
@reta
Switch to built-in security transports from core (#4119)
e2a06f0 
### Description
The security plugin does not need to provide the secure transports
anymore but SecureSettingsFactory so the core transport modules will be
able to configure those.

### Issues Resolved
Closes #4118

Is this a backport? If so, please add backport PR # and/or commits #

### Testing
[Please provide details of testing done: unit testing, integration
testing and manual testing]

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Andriy Redko <[email protected]>
reta added a commit to reta/security that referenced this issue Mar 26, 2024
@reta
Switch to built-in security transports from core (opensearch-project#…
ebb5d5d 
…4119)

The security plugin does not need to provide the secure transports
anymore but SecureSettingsFactory so the core transport modules will be
able to configure those.

Closes opensearch-project#4118

Is this a backport? If so, please add backport PR # and/or commits #

[Please provide details of testing done: unit testing, integration
testing and manual testing]

- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit e2a06f0)
dlin2028 pushed a commit to dlin2028/security that referenced this issue May 1, 2024
@reta @dlin2028
Switch to built-in security transports from core (opensearch-project#…
882bb4a 
…4119)

### Description
The security plugin does not need to provide the secure transports
anymore but SecureSettingsFactory so the core transport modules will be
able to configure those.

### Issues Resolved
Closes opensearch-project#4118

Is this a backport? If so, please add backport PR # and/or commits #

### Testing
[Please provide details of testing done: unit testing, integration
testing and manual testing]

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Andriy Redko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reta reta

Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v2.14.0 Issues and PRs related to version 2.14.0 v3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to built-in security transports from core reta/security
2 participants
@reta @cwperks