Revert "Adds a check to skip serialization-deserialization if request is for same node (#2765) (#2973) #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.9 #3046 +/- ##
=============================================
- Coverage 62.24% 32.48% -29.76%
+ Complexity 3310 1579 -1731
=============================================
Files 264 264
Lines 19468 19460 -8
Branches 3326 3319 -7
=============================================
- Hits 12117 6321 -5796
- Misses 5722 12077 +6355
+ Partials 1629 1062 -567
|
… is for same node (opensearch-project#2765) (opensearch-project#2973)" This reverts commit ddbe517. Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
revert-2765
branch
from
55618b6
to
297e4cb
Compare
|
Converting it to draft until we identify whether it will have to be reverted. |
|
@DarshitChanpura Can this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was identified #3021 (comment) where un-reproducible test failures were observed, which suggest that #2973 might be the culprit.
We are reverting the commit ddbe517 until we have 100% confidence in ensuring that this PR is not the root cause.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.