Replaced uses of SecurityRoles by Set<String> mappedRoles where the SecurityRoles functionality is not needed

[nibix]

Description

This code change is just in preparation for the change in #4380 as requested in #4380 (comment) .

In the course of #4380 , the SecurityRoles class will be replaced by a new concept. This PR already replaces the usages of SecurityRoles where no methods are used on it except the getRoleNames() method. This method call can be easily replaced by the Set<String> mappedRoles, which is computed by PrivilegesEvaluator before the SecurityRoles instance is created. This change elliminated the coupling of the interfaces that consume that information to the SecurityRoles class, thereby enhancing code quality.

• Category: Refactoring
• Why these changes are required? The changes in Optimized Privilege Evaluation #4380 will abolish the SecurityRoles class in the end.
• What is the old behavior before changes and new behavior after changes? No behavioral changes.

Issues Resolved

• Optimized Privilege Evaluation #4380 (comment)

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

• New functionality includes testing - no new functionality
• New functionality has been documented - no new functionality
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[nibix]

@peternied @cwperks @reta I am getting test failures on DelegatingRestHandlerTests - I guess this is a regression caused by the changes done in opensearch-project/OpenSearch#13772 to RestHandler. I guess this can be fixed by adding supportsStreaming() to DelegatingRestHandler.

[reta]

@peternied @cwperks @reta I am getting test failures on DelegatingRestHandlerTests

Fixing it right away, thank you @nibix

[nibix]

@reta Thanks for the quick fix!

[nibix]

@peternied @reta I am getting now another CI failure where I am a bit lost. Maybe someone of you has an idea?

* Where:
Build file '/home/runner/work/security/security/build.gradle' line: 473

* What went wrong:
A problem occurred evaluating root project 'opensearch-security'.
> Cannot change resolution strategy of dependency configuration ':runtimeClasspath' after it has been resolved.

However, gradlew assemble on my own system runs fine.

[reta]

@peternied @reta I am getting now another CI failure where I am a bit lost. Maybe someone of you has an idea?

@nibix fix is coming shortly , very unfortunate you run into those, apologies for that

[nibix]

I ran into more CI issues, a fix is here: #4446

[cwperks]

@nibix I'm not sure why some of the tests have not run. Can you rebase and push to see if it kicks off the CI checks? I'm not able to force start them.

[nibix]

@cwperks Done, but we had again test failures in a windows job. Would you mind to restart this one again?

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.43%. Comparing base (c1872b6) to head (3817416).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4432      +/-   ##
==========================================
- Coverage   65.44%   65.43%   -0.01%     
==========================================
  Files         312      312              
  Lines       22042    22037       -5     
  Branches     3559     3557       -2     
==========================================
- Hits        14425    14420       -5     
  Misses       5843     5843              
  Partials     1774     1774              

Files	Coverage Δ
...earch/security/privileges/PrivilegesEvaluator.java	72.17% <50.00%> (+0.05%)	⬆️
...rity/privileges/ProtectedIndexAccessEvaluator.java	74.46% <66.66%> (+0.99%)	⬆️

... and 1 file with indirect coverage changes