Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded provider #4587

Conversation

terryquigleysas
Copy link
Contributor

@terryquigleysas terryquigleysas commented Jul 22, 2024

Description

Category (Refactoring)
Remove call to add the BouncyCastleProvider in OpenSearchSecurityPlugin.java and any associated code.
This may have several benefits:

  • Removal of unnecessary code
  • Helps towards potential support of FIPS-compatible Bouncy Castle provider
  • Removes another SecurityManager referenc

Issues Resolved

Resolves #4583

Testing

Bulk Integration Test Github action

Run latest 3.x Core and OpenSearch Security plugin. Smoke tests (Indexing, searching, user creation, role creation, security admin script calls) run against both:

  • JDK 17 - local
  • JDK 21 - shipped with OS

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hardcoded security provider
1 participant